-
Notifications
You must be signed in to change notification settings - Fork 703
otelhttp: Deprecate DefaultClient #8140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
otelhttp: Deprecate DefaultClient #8140
Conversation
cb256d4 to
11fbd26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8140 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 194 194
Lines 13362 13362
=====================================
Hits 10931 10931
Misses 2033 2033
Partials 398 398
🚀 New features to boost your workflow:
|
1589ed8 to
0c5a22d
Compare
|
As mentioned in: #8131 (comment), we need to first mark it as deprecated before proceeding with the replacement. We need to give users a transition period. I suggest that you discuss and confirm the specific details of the deprecation and replacement plan on the issue page so that we can proceed with the follow-up work. PS: This issue is expected to be split into multiple phases for implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0c5a22d to
79904a3
Compare
pellared
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at other "deprecation" PRs for reference such as #8117
| "strings" | ||
| ) | ||
|
|
||
| // Deprecated: This will be deleted in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document what the user should do instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what user needs to do next, I assumed that since we are going to delete this they need to initialise a client on theirselves.
makes defaultClient private and creates a function that initialises it only once.
created for issue: #8131