refactor(otelhttp): change Version() func to const Version string #8142
+9
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Apologies, I've updated the changelog.md. |
dogedede
force-pushed
the
fix-const-version
branch
from
1f64ab7 to
0a266f5
Compare
dmathieu
reviewed
Nov 7, 2025
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Change `Version()` function in `otelhttp` package to a `const Version` string. (#8134) |
Member
There was a problem hiding this comment.
Changelog entries need to be at the beginning of the file. Not its end.
Member
There was a problem hiding this comment.
Buddy, look at the content of the file. You can surely see your last commit is also wrong.
Author
There was a problem hiding this comment.
Sorry for the laughably silly mix-up , I’ve moved the content to the right place.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8142 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 194 193 -1
Lines 13362 13360 -2
=======================================
- Hits 10931 10929 -2
Misses 2033 2033
Partials 398 398
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8134
Changes the Version() definition in the otelhttp package from a function to a constant string for simplicity and consistency.