Add context to periodic reader #6936
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our usage of this we make use of
slogcontext methods - i.e.slog.InfoContextAs the periodic reader uses a
context.Background()this is causing issues with our logging as we are missing required data from the context.I think that ideally
NewPeriodicReaderwould take acontext.Contextas it's first parameter - i.e.func NewPeriodicReader(ctx context.Context, exporter Exporter, options ...PeriodicReaderOption) *PeriodicReader {However this would be a breaking change which may be undesirable.
There are few of option I believe.
NewPeriodicReaderContextthat receives the context - this would be the least code changeNewPeriodicReaderThis PR shows the code required for option 1.
If option 2 of
NewPeriodicReaderContextis preferred then I'm happy to create that PR instead.Thanks!