Skip to content

[WIP] Encapsulate the trace SDK observability #7316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 13 commits into from
Closed

[WIP] Encapsulate the trace SDK observability #7316

wants to merge 13 commits into from

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 5, 2025

No description provided.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 5, 2025
@codecov
Copy link

codecov bot commented Sep 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.60140% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.0%. Comparing base (07a91dd) to head (c210151).

Files with missing lines Patch % Lines
sdk/trace/batch_span_processor.go 85.7% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7316   +/-   ##
=====================================
  Coverage   82.9%   83.0%           
=====================================
  Files        266     268    +2     
  Lines      24984   25010   +26     
=====================================
+ Hits       20733   20762   +29     
+ Misses      3876    3873    -3     
  Partials     375     375
Files with missing lines Coverage Δ
sdk/trace/internal/observ/batch_span_processor.go 100.0% <100.0%> (ø)
sdk/trace/internal/observ/tracer.go 100.0% <100.0%> (ø)
sdk/trace/provider.go 86.6% <100.0%> (-0.8%) ⬇️
sdk/trace/span.go 85.4% <100.0%> (+<0.1%) ⬆️
sdk/trace/tracer.go 100.0% <100.0%> (ø)
sdk/trace/batch_span_processor.go 80.9% <85.7%> (-2.9%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias force-pushed the enc-trace-sdk-obs branch 2 times, most recently from d3d8b44 to 576acf8 Compare September 8, 2025 15:08
This was referenced Sep 8, 2025
Merged
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 8, 2025

Superseded by #7331 and #7332

@MrAlias MrAlias closed this Sep 8, 2025
MrAlias added a commit that referenced this pull request Sep 15, 2025
@MrAlias
Encapsulate SDK BatchSpanProcessor observability (#7332)
e4ab314 
Split from #7316 

[Follow
guidelines](https://github.com/open-telemetry/opentelemetry-go/blob/a5dcd68ebb2f3669f7685ac7b0f3f1624251a381/CONTRIBUTING.md#encapsulation)
and move instrumentation into its own type.

### Benchmarks

#### Added `sdk/trace/internal/observ` benchmarks

```
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/trace/internal/observ
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
                         │ enc-trace-sdk-bsp-obs.out │
                         │          sec/op           │
BSP/Processed-8                        0.6394n ±  2%
BSP/ProcessedQueueFull-8               0.6806n ±  3%
BSP/Callback-8                          3.591µ ± 12%
geomean                                 11.60n

                         │ enc-trace-sdk-bsp-obs.out │
                         │           B/op            │
BSP/Processed-8                         0.000 ± 0%
BSP/ProcessedQueueFull-8                0.000 ± 0%
BSP/Callback-8                        2.626Ki ± 0%
geomean                                            ¹
¹ summaries must be >0 to compute geomean

                         │ enc-trace-sdk-bsp-obs.out │
                         │         allocs/op         │
BSP/Processed-8                         0.000 ± 0%
BSP/ProcessedQueueFull-8                0.000 ± 0%
BSP/Callback-8                          16.00 ± 0%
geomean                                            ¹
¹ summaries must be >0 to compute geomean
```

#### Existing `sdk/trace` benchmarks

None
MrAlias added a commit that referenced this pull request Sep 15, 2025
@MrAlias
Encapsulate SDK Tracer observability (#7331)
5b808c6 
Split from #7316 

[Follow
guidelines](https://github.com/open-telemetry/opentelemetry-go/blob/a5dcd68ebb2f3669f7685ac7b0f3f1624251a381/CONTRIBUTING.md#encapsulation)
and move instrumentation into its own type.

### Benchmarks

#### Added `sdk/trace/internal/observ` benchmarks

```
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/trace/internal/observ
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
                     │ enc-trace-sdk-tracer-obs.out │
                     │            sec/op            │
Tracer/SpanStarted-8                    7.436n ± 6%
Tracer/SpanLive-8                       9.987n ± 8%
Tracer/SpanEnded-8                      11.32n ± 7%
NewTracer-8                             87.64n ± 6%
geomean                                 16.48n

                     │ enc-trace-sdk-tracer-obs.out │
                     │             B/op             │
Tracer/SpanStarted-8                   0.000 ± 0%
Tracer/SpanLive-8                      0.000 ± 0%
Tracer/SpanEnded-8                     0.000 ± 0%
NewTracer-8                            0.000 ± 0%
geomean                                           ¹
¹ summaries must be >0 to compute geomean

                     │ enc-trace-sdk-tracer-obs.out │
                     │          allocs/op           │
Tracer/SpanStarted-8                   0.000 ± 0%
Tracer/SpanLive-8                      0.000 ± 0%
Tracer/SpanEnded-8                     0.000 ± 0%
NewTracer-8                            0.000 ± 0%
geomean                                           ¹
¹ summaries must be >0 to compute geomean
```

#### Existing `sdk/trace` benchmarks

```console
> benchstat main.out enc-trace-sdk-tracer-obs.out
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/sdk/trace
cpu: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
                                  │  main.out   │     enc-trace-sdk-tracer-obs.out     │
                                  │   sec/op    │    sec/op     vs base                │
SpanEnd/ObservabilityEnabled-8      188.5n ± 4%   131.5n ± 32%  -30.24% (p=0.000 n=10)
TraceStart/ObservabilityEnabled-8   886.9n ± 8%   663.9n ±  2%  -25.14% (p=0.000 n=10)
geomean                             408.9n        295.5n        -27.73%

                                  │  main.out  │      enc-trace-sdk-tracer-obs.out       │
                                  │    B/op    │    B/op     vs base                     │
SpanEnd/ObservabilityEnabled-8      16.00 ± 0%    0.00 ± 0%  -100.00% (p=0.000 n=10)
TraceStart/ObservabilityEnabled-8   608.0 ± 0%   576.0 ± 0%    -5.26% (p=0.000 n=10)
geomean                             98.63                    ?                       ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean

                                  │  main.out  │      enc-trace-sdk-tracer-obs.out       │
                                  │ allocs/op  │ allocs/op   vs base                     │
SpanEnd/ObservabilityEnabled-8      1.000 ± 0%   0.000 ± 0%  -100.00% (p=0.000 n=10)
TraceStart/ObservabilityEnabled-8   5.000 ± 0%   3.000 ± 0%   -40.00% (p=0.000 n=10)
geomean                             2.236                    ?                       ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean
```

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XSAM XSAM Awaiting requested review from XSAM XSAM will be requested when the pull request is marked ready for review XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole will be requested when the pull request is marked ready for review dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared will be requested when the pull request is marked ready for review pellared is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu will be requested when the pull request is marked ready for review dmathieu is a code owner

@flc1125 flc1125 Awaiting requested review from flc1125 flc1125 will be requested when the pull request is marked ready for review flc1125 is a code owner

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@MrAlias