Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 11, 2025

Fix #7356

Do not use the user-defined empty set when comparing sets.
@MrAlias MrAlias added this to the v1.39.0 milestone Sep 11, 2025
@MrAlias MrAlias added bug Something isn't working pkg:attribute Related to the attribute package labels Sep 11, 2025
@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.5%. Comparing base (01611d3) to head (6b14db0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
attribute/set.go 85.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7357     +/-   ##
=======================================
- Coverage   82.9%   82.5%   -0.5%     
=======================================
  Files        267     267             
  Lines      24982   25063     +81     
=======================================
- Hits       20729   20690     -39     
- Misses      3877    3956     +79     
- Partials     376     417     +41     
Files with missing lines Coverage Δ
attribute/set.go 44.9% <85.7%> (-38.3%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias marked this pull request as ready for review September 11, 2025 21:40
@MrAlias MrAlias merged commit 59563f7 into open-telemetry:main Sep 15, 2025
32 checks passed
@MrAlias MrAlias deleted the fix-7356 branch September 15, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pkg:attribute Related to the attribute package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The empty set value should not change set equality

5 participants