Generate gRPC Client target parsing func #7424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to add gRPC server attributes for exporter observability, this information needs to be parsed into a host and port. The added generated files provides ParseCanonicalTarget for this functionality. This is added as a generated template as it is expected to be needed for all OTLP exporters (e.g. open-telemetry#7404, open-telemetry#7353).
MrAlias
added
Skip Changelog
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7424 +/- ##
=====================================
Coverage 85.5% 85.5%
=====================================
Files 278 279 +1
Lines 24654 24714 +60
=====================================
+ Hits 21089 21146 +57
- Misses 3186 3189 +3
Partials 379 379
🚀 New features to boost your workflow:
|
MrAlias
requested review from
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
Member
|
LGTM |
flc1125
approved these changes
Sep 27, 2025
dmathieu
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add gRPC server attributes for exporter observability, this information needs to be parsed into a host and port. The added generated files provides
ParseCanonicalTargetfor this functionality.This is added as a generated template as it is expected to be needed for all OTLP exporters (e.g. #7404, #7353).
Split from work added to #7404
cc @yumosx
Benchamarks