-
Notifications
You must be signed in to change notification settings - Fork 926
add "get" method to DeclarativeConfigProperties #7923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jack-berg
merged 5 commits into
open-telemetry:main
from
zeitlinger:declarative-config-get
Dec 18, 2025
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fae075d
add "get" method to DeclarativeConfigProperties
zeitlinger d914d52
Update api/incubator/src/main/java/io/opentelemetry/api/incubator/con…
zeitlinger 2f5876e
add "get" method to DeclarativeConfigProperties
zeitlinger 0eacadc
Update api/incubator/src/main/java/io/opentelemetry/api/incubator/con…
zeitlinger b7ebfeb
fix
zeitlinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt of not throwing exception for this (and other) methods which have default values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we took this approach I think we'd want to go further and get rid of the the throws altogether. It would be strange if calling the non-default overload threw (rather than just returning null) while the default did not.
Going in this direction means we remove the ability to detect / handle schema type mismatches. It seems like a version of the "fail fast" vs. "handle gracefully and trudge on".
But hold on... the default
YamlDeclarativeConfigPropertiesimplementation does warn you if there is a type mismatch, but never throws! So all of these warnings are fake!I do wonder if we should provide abilities to detect schema type mismatches and fail fast. API could look like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in the 12/18 java SIG and decided that:
opentelemetry-java-instrumentationhas a preference for failing graceful (at least for now - we discussed both options in detail)Ignoring value for key [foo] because it is String instead of Integer: valueIgnoring value for property [full.path.to.foo] because it is String instead of Integer: valueThe work to strip out the
@throws DeclarativeConfigExceptionto reflect current behavior, and to improve error log messages can be done in separate PRs.