Skip to content

Conversation

@anuraaga
Copy link
Contributor

Very similar to #7895 but for logs

@anuraaga anuraaga requested a review from a team as a code owner December 19, 2025 07:03
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 95.18717% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.11%. Comparing base (22d90b6) to head (ef71262).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...metry/sdk/logs/export/BatchLogRecordProcessor.java 80.00% 2 Missing and 1 partial ⚠️
...entelemetry/sdk/logs/SdkLoggerInstrumentation.java 91.30% 0 Missing and 2 partials ⚠️
...etry/sdk/logs/export/SimpleLogRecordProcessor.java 83.33% 1 Missing and 1 partial ⚠️
...xport/LegacyLogRecordProcessorInstrumentation.java 97.87% 0 Missing and 1 partial ⚠️
...port/SemConvLogRecordProcessorInstrumentation.java 98.07% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               main    #7931    +/-   ##
==========================================
  Coverage     90.10%   90.11%            
- Complexity     7370     7411    +41     
==========================================
  Files           828      833     +5     
  Lines         22254    22396   +142     
  Branches       2192     2200     +8     
==========================================
+ Hits          20053    20183   +130     
- Misses         1515     1520     +5     
- Partials        686      693     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for working on this!

void finishLogs(int count, @Nullable String error);

/** Registers metrics for processor queue capacity and size. */
void buildQueueMetricsOnce(long capacity, LongCallable getSize);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that its a conscious decision to repeat LongCallable here to avoid more internal shared code.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@jack-berg jack-berg merged commit 23799f2 into open-telemetry:main Dec 19, 2025
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Dec 19, 2025

Thank you for your contribution @anuraaga! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants