-
Notifications
You must be signed in to change notification settings - Fork 926
Implement SDK metrics for logs #7931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7931 +/- ##
==========================================
Coverage 90.10% 90.11%
- Complexity 7370 7411 +41
==========================================
Files 828 833 +5
Lines 22254 22396 +142
Branches 2192 2200 +8
==========================================
+ Hits 20053 20183 +130
- Misses 1515 1520 +5
- Partials 686 693 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for working on this!
| void finishLogs(int count, @Nullable String error); | ||
|
|
||
| /** Registers metrics for processor queue capacity and size. */ | ||
| void buildQueueMetricsOnce(long capacity, LongCallable getSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that its a conscious decision to repeat LongCallable here to avoid more internal shared code.
jkwatson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Very similar to #7895 but for logs