feat(collector): optimize telemetryapireceiver trace and span id generation #2084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
crypto/rand'sReadmethod directly. Instead of reinitializing and seeding the rng on each span / trace id generation. Saving:rand.NewSource(rngSeed)rand.New(...)rand.NewSource(rngSeed)- PRNG state initialization (also apparently not safe for concurrent use)rand.NewSource(rngSeed)andrand.New(...)What remains now is basically a very efficient syscall, with no heap allocations.