Ability to configure Collector's Service, Headless Service, Monitoring Service and Extension Service #4258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
force-pushed
the
configure-collector-services
branch
2 times, most recently
from
e3cefe7 to
c8a51c7
Compare
sky333999
commented
Aug 6, 2025
Makefile
Outdated
| cd $$TMP_DIR ;\ | ||
| go mod init tmp ;\ | ||
| echo "Downloading $(2)" ;\ | ||
| echo "replace fybrik.io/crdoc => github.com/fybrik/crdoc v0.5.2" >> go.mod ;\ |
Author
There was a problem hiding this comment.
fybrik.io domain seems to have expired. So adding a replace temporarily.
Idk why this is a problem just for me. Is is that the go mod cached on the GH runners for the actions?
| Annotations: map[string]string{}, | ||
| }, | ||
| }, | ||
| &networkingv1.Ingress{ |
Author
There was a problem hiding this comment.
Just a re-ordering since now services are created after the ingress in collector.go.
jaronoff97
reviewed
Aug 6, 2025
|
|
||
| // Service to override configuration of the generated Collector Service. | ||
| // +optional | ||
| Service ServiceSpec `json:"service,omitempty"` |
Contributor
There was a problem hiding this comment.
there's no need to edit the v1alpha1 resources, these are deprecated and we shouldnt be touching them anymore.
Author
There was a problem hiding this comment.
Sounds good. I can revert the changes and remove the changes to the converter as well.
sky333999
force-pushed
the
configure-collector-services
branch
from
520d45d to
ec2bfc3
Compare
Contributor
# Conflicts: # bundle/community/manifests/opentelemetry-operator.clusterserviceversion.yaml # bundle/openshift/manifests/opentelemetry-operator.clusterserviceversion.yaml
# Conflicts: # Makefile # bundle/community/manifests/opentelemetry.io_opentelemetrycollectors.yaml # bundle/openshift/manifests/opentelemetry.io_opentelemetrycollectors.yaml # config/crd/bases/opentelemetry.io_opentelemetrycollectors.yaml # docs/api/opentelemetrycollectors.md # internal/manifests/collector/collector_test.go
Contributor
|
@sky333999 @jaronoff97 @yuriolisa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Disabledinstead ofEnabledsuch that it initializes to false when not set and the behavior stays the same.nilimplies retain old behavior.Link to tracking Issue(s):
spec.observability.metrics.disableMonitoringService#4242Testing:
Unit Testing
Local Testing
Validation: Daemonset is created, all 4 services are created. No observable change in behavior.
Validation: Apply failed complaining the CRD did not recognize the new field. Expected behavior.
Validation: Apply was successful; The ClusterIP service is deleted.
Validation: All 4 services are deleted.
Validation: Only the ClusterIP service is recreated and has the overridden name.
E2E Testing
Documentation: CRDs are self-documenting, no further changes made.