add image pull secrets in otel collector spec #4377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hritik003 <[email protected]>
|
|
Hritik003
changed the title
Signed-off-by: Hritik003 <[email protected]>
Signed-off-by: Hritik003 <[email protected]>
Author
|
@atoulme @iblancasa @TylerHelmuth @yuriolisa |
iblancasa
reviewed
Nov 20, 2025
Contributor
iblancasa
left a comment
iblancasa
left a comment
There was a problem hiding this comment.
Thanks for the PR.
I would like to see some E2E tests. Can you add them?
Also: why support for sidecar is not being added?
| var imagePullSecrets []corev1.LocalObjectReference | ||
|
|
||
| // Check each instrumentation type for imagePullSecrets | ||
| if insts.Java.Instrumentation != nil && len(insts.Java.Instrumentation.Spec.ImagePullSecrets) > 0 { |
Contributor
There was a problem hiding this comment.
Is there any reason to not insts.Java.Instrumentation.Spec.ImagePullSecrets != ""?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request adds support for specifying
ImagePullSecretsin the OpenTelemetry Collector Kubernetes resources, allowing users to configure secrets for pulling container images from private registries. The implementation includes updates to the API, resource generation logic, and comprehensive unit tests to verify the new functionality.API and Struct Enhancements:
ImagePullSecretsfield to theOpenTelemetryCommonFieldsstruct, enabling users to specify secrets for image pulls in the custom resource definition.DeepCopyIntomethod to handle deep copying of the newImagePullSecretsfield.Resource Generation Updates:
Deployment,DaemonSet, andStatefulSetmanifest generation functions to set theImagePullSecretsfield in the resulting Kubernetes resource specs, based on the custom resource configuration. [1] [2] [3]Testing Improvements:
Added new unit tests for
Deployment,DaemonSet, andStatefulSetresource generation to verify correct handling of theImagePullSecretsfield, including both default (unset) and explicitly set scenarios. [1] [2] [3]Ex. Adding a feature - Explain what this achieves.-->
Resolves: Support for Image pull secret in the open telemetry collector spec #4376
Testing:
Documentation: