for deamonset copy only spec.config not entore deepcopy #4482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
reviewed
Nov 6, 2025
Member
frzifus
left a comment
frzifus
left a comment
There was a problem hiding this comment.
ty @Nitesh-vaidyanath - I think you need to follow the easyCLA process to get this merged.
Member
|
You may also want to add a changelog entry for this fix. You can generate a template using |
Nitesh-vaidyanath
force-pushed
the
issue-4481
branch
from
d55a694 to
da8725d
Compare
jaronoff97
reviewed
Nov 7, 2025
| note: "OpAMP Bridge: collector.DeepCopy() causes full spec updates → DaemonSet mode fails (should patch spec.config only)" | ||
|
|
||
| # One or more tracking issues related to the change | ||
| issues: [https://github.com/open-telemetry/opentelemetry-operator/pull/4482] |
Contributor
There was a problem hiding this comment.
you can just provide an issue number here
Comment on lines
+107
to
+109
| if instance.Spec.Mode == v1beta1.ModeDaemonSet { | ||
| return c.updateConfigOnly(ctx, instance, updatedCollector) | ||
| } |
Contributor
There was a problem hiding this comment.
can we add to an existing e2e test to verify this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue(s):
Testing:
Documentation: