Skip to content

Conversation

@didiViking
Copy link
Contributor

Related to #8088

@didiViking didiViking requested a review from a team as a code owner October 14, 2025 16:12
@didiViking didiViking self-assigned this Oct 14, 2025
@otelbot-docs otelbot-docs bot requested review from a team October 14, 2025 16:13
@didiViking
Copy link
Contributor Author

@chalin Hi, is this last failed error for check links related to false positives? Most of the pages are not yet translated into Romanian, they are linked as per the English version. Please advise, thank you!

@chalin
Copy link
Contributor

chalin commented Oct 15, 2025

@chalin Hi, is this last failed error for check links related to false positives? Most of the pages are not yet translated into Romanian, they are linked as per the English version. Please advise, thank you!

Hi. No, these are real failures. If you inspect the log at https://github.com/open-telemetry/opentelemetry.io/actions/runs/18516852373/job/52769038456?pr=8093, you'll see that it's complaining about missing Header IDs (hashes):

ro/docs/concepts/glossary/index.html
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #metric
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #data-source
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #data-source
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #service
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #metadata
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #signal
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #resource
...

@vitorvasc vitorvasc added the sig-approval-missing Co-owning SIG didn't provide an approval label Oct 16, 2025
@didiViking
Copy link
Contributor Author

@chalin Hi, I'm trying to fix the Check Links errors, but the error details point me to some other languages files. I'm blocked in this PR and I'm not sure how to fix this.
@theletterf Any advice from tech writers highly appreciated. Thank you!

Copy link
Member

@vitorvasc vitorvasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @didiViking!

I can see what is happening here, there are a few things you should do to address the issue with the links, I'll leave some inline comments.

@vitorvasc
Copy link
Member

Feel free to reorder the headings alphabetically as well, it helps keep the glossary consistent and easier to navigate. 🙂

@otelbot-docs otelbot-docs bot requested a review from a team October 30, 2025 12:37
@didiViking
Copy link
Contributor Author

@vitorvasc Thank you for the tips and examples. Now I fixed all missing Header IDs and it's failing due to some Portuguese broken links. Any ideas?

@vitorvasc
Copy link
Member

@vitorvasc Thank you for the tips and examples. Now I fixed all missing Header IDs and it's failing due to some Portuguese broken links. Any ideas?

I don't see the Portuguese broken links in the history, could you share which ones you're referring to?

From what I can see in the last run, there are still three remaining errors in content/ro/docs/concepts/glossary.md:

ro/docs/concepts/glossary/index.html
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #distributions
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #receptors
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #signals

@didiViking
Copy link
Contributor Author

@vitorvasc Thank you for the tips and examples. Now I fixed all missing Header IDs and it's failing due to some Portuguese broken links. Any ideas?

I don't see the Portuguese broken links in the history, could you share which ones you're referring to?

From what I can see in the last run, there are still three remaining errors in content/ro/docs/concepts/glossary.md:

ro/docs/concepts/glossary/index.html
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #distributions
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #receptors
  hash does not exist --- ro/docs/concepts/glossary/index.html --> #signals

I corrected "receptors" but both "distributions" and "signals" are in the plural form in this error but in singular form in the original Header. I tried adding both plural and singular forms and the CI/CD it's still complaining.

@didiViking
Copy link
Contributor Author

@vitorvasc @theletterf
I'm left with "signals", in this page both "signal" and "signals" exist as hash. If I change it to plural or singular form it complaints the other form doesn't exist. If anyone has an idea how to fix this, please let me know. Thanks!
Screenshot 2025-10-30 at 18 01 09

@otelbot-docs otelbot-docs bot requested a review from a team October 31, 2025 10:07
@didiViking
Copy link
Contributor Author

@vitorvasc All checks passed, I added all original links at the bottom of the text. Could you please review? I still need to pass this through a Romanian content review. Thank you!

Copy link
Member

@vitorvasc vitorvasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few inline suggestions, that should cover all the link labels now. Let me know if you have any questions 🙂

@otelbot-docs otelbot-docs bot requested a review from a team November 6, 2025 13:07
@didiViking
Copy link
Contributor Author

didiViking commented Nov 6, 2025

@IrinaKarantoniou Thank you for your comments on slack for this PR, I add them here for visibility:
10 - 11 din cadrul proiectului
14 oferim comentarii privind ortografia și scrierea cu... ,22 schimbă despre cu referitoare la
93 - în principiu în textul în engleză se referă la faptul că collector este un substantiv atributiv, în română nu există așa ceva, se utilizează genitivul, vezi exemplul tău "Configurația colectorului", deci ar trebui să schimbăm chestia asta, 100 - scrie doar "contrib", mai trebuia să fie ceva? 203 - "pentru a evita ambiguitatea", 232 - 233 "Se pot enumera, de exemplu, instrumente open source...", 327 - nu e mai bine "sub forma unor [Atribute]" în loc de "ca [Atribute]"?

10-11 DONE
14 DONE
22 Can't find this (please provide the entire paragraph)
93- I don't get your suggestion
100- contrib is mentioned as per English version, this refers to a specific form of Collector called "contrib". Hence I didn't make the automatic, logical translation to the Romanian "contributie", as it refers to a specific collector type.
203-No. In the original sentence in English, it's written: "Log
Sometimes used to refer to a collection of Log records. Can be ambiguous since people also sometimes use Log to refer to a single Log record." So log can be ambiguous since people ...". I kept this meaning in Romanian, hence: Poate fi ambiguu ...
232-233- DONE
327 DONE

@IrinaKarantoniou
Copy link

@didiViking
22 - "despre măsurătorile care au avut loc într-un interval de timp", what do you think about "referitoare la măsurătorile"?
93 - Colector ca adjectiv — de exemplu, „Configurația colectorului”. Is this an explanation for when we use the word "colector" as an adjective? If so, in Romanian, the word "colectorului" is not an adjective but it is a noun in the genitive case.

@IrinaKarantoniou
Copy link

LGTM

@didiViking
Copy link
Contributor Author

@vitorvasc All Romanian corrections have been applied, good to send to merge queue. Thank you!

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will let @vitorvasc have a final say, as well as @open-telemetry/docs-ro-approvers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs lang:ro sig-approval-missing Co-owning SIG didn't provide an approval

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants