-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[pt][editorial] Java API - fix link for (upcoming) specs reference #8366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: chalin <[email protected]>
|
@copilot Explain the nature of the link-check failure. Which PR check is failing, and why? |
The CHECK LINKS (locales-N-to-Z) job in the Links workflow is failing. The specific error is: This is a broken anchor link in the Portuguese translation of the Java API docs ( This failure was introduced by PR #8183's changes to the opentelemetry-specification submodule (updated from v1.50.0 to v1.50.0-11-gd5cfbdf). The specification update likely removed or renamed the |
Fixes the broken anchor link in Portuguese Java API docs from `#standard-attribute` to `#attribute` to match the spec changes. This follows the same fix applied in #8287 (English and Japanese) and #8291 (Chinese) but was missed for the Portuguese translation. Co-authored-by: chalin <[email protected]>
Applied the same fix from #8287 and #8291 to the Portuguese translation. Updated the link from Commit: 7ef3874 |
|
@copilot A few comments:
|
- Added `# patched` to default_lang_commit in Portuguese Java API docs following localization guidelines - Removed unnecessary .htmltest.yml change (anthropic.com) which was not related to the link check failure in PR #8183 Co-authored-by: chalin <[email protected]>
Addressed both points:
The changes now match the pattern from #8287 (Japanese) and #8291 (Chinese). Commit: b531cbc Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
chalin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once all checks pass.
I don't have the ability to rebase PR #8183 since it's owned by the otelbot-docs bot and I cannot push to the The rebase would need to be triggered by someone with appropriate permissions or through the bot's automation. Once this PR is merged, #8183 should automatically pick up the fix when it's rebased against the updated main branch. |
Fixes the broken anchor link in the Portuguese translation of the Java API documentation that was causing link check failures in PR #8183.
Problem
The specification update in PR #8183 (opentelemetry-specification v1.50.0 to v1.50.0-11-gd5cfbdf) removed the
#standard-attributeanchor and replaced it with#attribute. This broke the link in the Portuguese Java API docs, causing the "CHECK LINKS (locales-N-to-Z)" job to fail with:Solution
Updated the link in
content/pt/docs/languages/java/api.mdfrom/docs/specs/otel/common/#standard-attributeto/docs/specs/otel/common/#attribute.Following the localization guidelines:
# patchedcomment to thedefault_lang_commitfront matter lineThis follows the same fix that was applied in:
The Portuguese translation was missed in those PRs and is now corrected.
Changes Made
content/pt/docs/languages/java/api.md(line 480)#standard-attributeto#attributeto match the updated specification# patchedmarker to thedefault_lang_commitfront matter per localization guidelinesRelated: #8287, #8291, open-telemetry/opentelemetry-specification#4712
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.