Change play stop to play pause symbols and test midi support to transport button #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi Jee-Bee, I have reviewed your change and it doesnt add the midi support for transport button, it seems like more changes need to be done here. The change to show the Pause play button is really nice however when the application first launches it still says "Stop" to fix this change this line: https://github.com/openAVproductions/openAV-Luppp/blob/master/src/gmastertrack.cxx#L203 @harryhaaren This PR is 4 years old, i think we should either close this and open a new PR or just merge it and update the above change in a subsequent PR. I dont think this closes #292 though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change play stop to play pause symbols and test midi support to transport button
and add virtual void to assign midi control to transport at least i hope so...
Maybe it helps for issue : #292