Skip to content

docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.#595

Open
wesley990 wants to merge 3 commits intoopenabdev:mainfrom
wesley990:patch-1
Open

docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.#595
wesley990 wants to merge 3 commits intoopenabdev:mainfrom
wesley990:patch-1

Conversation

@wesley990
Copy link
Copy Markdown

@wesley990 wesley990 commented Apr 27, 2026

Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.
Per https://discord.com/channels/1491295327620169908/1491365158868619404/1498273257214840862

Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.
@wesley990 wesley990 requested a review from thepagent as a code owner April 27, 2026 10:32
@github-actions github-actions Bot added closing-soon PR missing Discord Discussion URL — will auto-close in 3 days pending-screening PR awaiting automated screening labels Apr 27, 2026
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model (optional).
@github-actions github-actions Bot removed the closing-soon PR missing Discord Discussion URL — will auto-close in 3 days label Apr 27, 2026
@wesley990 wesley990 changed the title Fix missing arguments in gemini.md Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model. Apr 27, 2026
@wesley990 wesley990 changed the title Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model. docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model. Apr 27, 2026
Copy link
Copy Markdown

@CHC-Agent CHC-Agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Verdict: 🟡 Minor issues → ✅ Fixed

What this PR does

Fixes two gaps in docs/gemini.md Helm install instructions:

  1. Adds missing --set agents.gemini.discord.enabled=true — without this, the [discord] config block is never generated and the bot token is never injected, so Gemini silently fails to connect to Discord.
  2. Documents how to specify a Gemini model via args (optional).

What was fixed in follow-up commit

  • Typo: defalutdefault
  • Formatting: extra leading space before (Optional), missing space before backtick

Verdict

Good to merge. The enabled=true fix addresses a real documentation bug that would block new users.

Copy link
Copy Markdown
Contributor

@masami-agent masami-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review: #595

Summary

  • Problem: docs/gemini.md Helm install example is missing agents.gemini.discord.enabled=true, which means the [discord] config block is never generated — Gemini silently fails to connect to Discord.
  • Approach: Add the missing flag and document optional model selection via args.
  • Risk level: Low (docs-only change)

Core Assessment

  1. Problem clearly stated: ✅ (referenced Discord discussion in PR body)
  2. Approach appropriate: ✅
  3. Alternatives considered: N/A (straightforward doc fix)
  4. Best approach for now: ✅

Findings

Verified against the chart templates:

  • configmap.yaml uses {{- if ($cfg.discord).enabled }} — without enabled=true, the entire [discord] block is omitted from config.toml, so the bot token is never configured. The fix is correct and necessary.
  • CHC-Agent's follow-up commit fixed the typo (defalutdefault) and formatting. Final state looks clean.

Review Summary

🔧 Suggested Changes

  • The "Manual config.toml" section below still shows only args = ["--acp"]. Consider adding a brief note there as well showing how to specify a model in TOML format (e.g., args = ["--model", "gemini-3-pro-preview", "--acp"]). This would keep both sections consistent. Not blocking — can be done in a follow-up PR.

⚪ Nits

  • PR title could be more concise: docs(gemini): add missing enabled flag and model args (minor, will be rewritten on squash merge anyway).

Verdict

APPROVE — correct and useful doc fix. Good to merge.

Copy link
Copy Markdown
Collaborator

@obrutjack obrutjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — correct and necessary doc fix. The enabled=true flag is required for the configmap template to generate the [discord] block. Clean final state after CHC-Agent's formatting fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending-screening PR awaiting automated screening

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants