docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.#595
Open
wesley990 wants to merge 3 commits intoopenabdev:mainfrom
Open
docs(markdown) Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.#595wesley990 wants to merge 3 commits intoopenabdev:mainfrom
wesley990 wants to merge 3 commits intoopenabdev:mainfrom
Conversation
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model (optional).
CHC-Agent
reviewed
Apr 30, 2026
CHC-Agent
left a comment
There was a problem hiding this comment.
Review Summary
Verdict: 🟡 Minor issues → ✅ Fixed
What this PR does
Fixes two gaps in docs/gemini.md Helm install instructions:
- Adds missing
--set agents.gemini.discord.enabled=true— without this, the[discord]config block is never generated and the bot token is never injected, so Gemini silently fails to connect to Discord. - Documents how to specify a Gemini model via
args(optional).
What was fixed in follow-up commit
- Typo:
defalut→default - Formatting: extra leading space before
(Optional), missing space before backtick
Verdict
Good to merge. The enabled=true fix addresses a real documentation bug that would block new users.
masami-agent
approved these changes
Apr 30, 2026
Contributor
masami-agent
left a comment
There was a problem hiding this comment.
PR Review: #595
Summary
- Problem:
docs/gemini.mdHelm install example is missingagents.gemini.discord.enabled=true, which means the[discord]config block is never generated — Gemini silently fails to connect to Discord. - Approach: Add the missing flag and document optional model selection via
args. - Risk level: Low (docs-only change)
Core Assessment
- Problem clearly stated: ✅ (referenced Discord discussion in PR body)
- Approach appropriate: ✅
- Alternatives considered: N/A (straightforward doc fix)
- Best approach for now: ✅
Findings
Verified against the chart templates:
configmap.yamluses{{- if ($cfg.discord).enabled }}— withoutenabled=true, the entire[discord]block is omitted fromconfig.toml, so the bot token is never configured. The fix is correct and necessary.- CHC-Agent's follow-up commit fixed the typo (
defalut→default) and formatting. Final state looks clean.
Review Summary
🔧 Suggested Changes
- The "Manual config.toml" section below still shows only
args = ["--acp"]. Consider adding a brief note there as well showing how to specify a model in TOML format (e.g.,args = ["--model", "gemini-3-pro-preview", "--acp"]). This would keep both sections consistent. Not blocking — can be done in a follow-up PR.
⚪ Nits
- PR title could be more concise:
docs(gemini): add missing enabled flag and model args(minor, will be rewritten on squash merge anyway).
Verdict
APPROVE — correct and useful doc fix. Good to merge.
obrutjack
approved these changes
Apr 30, 2026
Collaborator
obrutjack
left a comment
There was a problem hiding this comment.
LGTM — correct and necessary doc fix. The enabled=true flag is required for the configmap template to generate the [discord] block. Clean final state after CHC-Agent's formatting fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding arguments of agents.gemini.discord.enabled=true and specify Gemini model.
Per https://discord.com/channels/1491295327620169908/1491365158868619404/1498273257214840862