Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the Codex app-server clientInfo.name default so the Claude Code plugin identifies itself with a Codex-namespaced client identifier, and adds a regression test to prevent reintroducing the old host-app name.
Changes:
- Rename the default
clientInfo.namefrom"Claude Code"to"codex_claude_code"in the app-server client. - Extend the fake Codex fixture to persist the
initializerequest payload for inspection. - Add a runtime regression test asserting the app-server is initialized with the namespaced client name.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
plugins/codex/scripts/lib/app-server.mjs |
Updates the default clientInfo.name used in app-server initialize requests. |
tests/fake-codex-fixture.mjs |
Captures and stores the last initialize payload in fixture state for assertions. |
tests/runtime.test.mjs |
Adds a regression test verifying the initialize payload contains the namespaced client name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #199
Summary
clientInfo.namefromClaude Codetocodex_claude_codeVerification
npm testnpm run build