Skip to content

fix: namespace app-server client info#255

Open
d3v07 wants to merge 1 commit intoopenai:mainfrom
d3v07:fix/199-client-info-name
Open

fix: namespace app-server client info#255
d3v07 wants to merge 1 commit intoopenai:mainfrom
d3v07:fix/199-client-info-name

Conversation

@d3v07
Copy link
Copy Markdown

@d3v07 d3v07 commented Apr 21, 2026

Closes #199

Summary

  • rename the default app-server clientInfo.name from Claude Code to codex_claude_code
  • capture the app-server initialize payload in the fake Codex fixture
  • add a regression test that verifies the plugin initializes Codex with the codex-namespaced client name

Verification

  • npm test
  • npm run build

@d3v07 d3v07 requested review from a team and Copilot April 21, 2026 18:15
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Codex app-server clientInfo.name default so the Claude Code plugin identifies itself with a Codex-namespaced client identifier, and adds a regression test to prevent reintroducing the old host-app name.

Changes:

  • Rename the default clientInfo.name from "Claude Code" to "codex_claude_code" in the app-server client.
  • Extend the fake Codex fixture to persist the initialize request payload for inspection.
  • Add a runtime regression test asserting the app-server is initialized with the namespaced client name.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugins/codex/scripts/lib/app-server.mjs Updates the default clientInfo.name used in app-server initialize requests.
tests/fake-codex-fixture.mjs Captures and stores the last initialize payload in fixture state for assertions.
tests/runtime.test.mjs Adds a regression test verifying the initialize payload contains the namespaced client name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clientInfo.name should use codex-namespaced identifier instead of host application name

2 participants