fix(voice): honor client config for streamed STT by sylvesterkaczmarek · Pull Request #4532 · openai/openai-agents-python

sylvesterkaczmarek · 2026-08-20T01:20:37Z

Summary

Make streamed OpenAI STT honor the supplied AsyncOpenAI client's endpoint, query, headers, and dynamic credentials instead of bypassing client configuration.

OpenAISTTTranscriptionSession previously connected directly to:

wss://api.openai.com/v1/realtime?intent=transcription

and constructed its authorization header directly from client.api_key. That bypassed client routing/query/header configuration and could also materialize an empty or stale credential when the client uses a callable API-key provider.

Fix

derive WebSocket routing from the configured OpenAI client
merge client.default_query with the same Omit / NotGiven semantics as Responses WebSocket
propagate auth/default headers while filtering omission sentinels
refresh callable/rotating API keys before materializing handshake headers
keep intent=transcription and OpenAI-Log-Session: 1 as STT-specific call-site values
centralize client-derived WebSocket URL/query/header/credential normalization in a shared internal helper used by both Responses WebSocket and streamed STT

Test plan

Coverage verifies:

custom base_url and websocket_base_url
merged client query parameters and omission semantics
auth, organization/project, and custom headers
omitted organization/project headers are not stringified
callable API keys are refreshed before the STT handshake
existing STT connection tests use client doubles with the routing/query/header attributes read by this path

Risk

Low. With the default OpenAI client configuration, streamed STT still connects to wss://api.openai.com/v1/realtime?intent=transcription. Behavior changes only for configured routing, headers, query parameters, or dynamic credentials.

Issue number

None. Found while auditing parity between streamed and non-streamed STT client configuration.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d40f222a9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-20T01:33:30Z

Note

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector · 2026-08-20T01:36:54Z

Note

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b6b1a35db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

seratch

Thanks for the contribution. The underlying issue is valid: streamed STT currently bypasses the supplied AsyncOpenAI client's endpoint, query, and header configuration.
Before merging, please update the existing STT connection test doubles with the URL, query, auth-header, and default-header attributes now read by this path; those tests currently fail before reaching the mocked connection. Please also incorporate the callable-key refresh and regression coverage from #4537 before materializing auth headers.

Finally, keep the client-derived WebSocket URL, query, header, and credential normalization in a shared internal helper used by both Responses WebSocket and streamed STT, while leaving each transport's endpoint suffix and fixed parameters at its call site.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcc8d57066

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-20T08:40:43Z

+def _is_openai_omitted_value(value: Any) -> bool:
+    return isinstance(value, Omit | NotGiven)


Reuse one WebSocket normalization path

This new module duplicates the omission detection, credential refresh, header merge, and base/query normalization already implemented in openai_responses.py, while the Responses transport continues using its private copies. Consequently, fixes to these client semantics can land in only one transport—the preceding revisions already needed several corrections in this exact area. Route both WebSocket transports through this helper, or adapt STT to the existing normalization, so there is one source of truth.

AGENTS.md reference: AGENTS.md:L93-L93

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 101108b502

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-20T08:51:32Z

+        for key, value in source.items():
+            if _is_openai_omitted_value(value):
+                continue


Remove inherited headers when defaults use Omit

When an AsyncOpenAI client uses default_headers={"Authorization": omit}—for example, to prevent an OpenAI key from being forwarded to a custom WebSocket proxy—the auth source has already inserted Authorization, and this branch merely skips the later sentinel instead of removing that inherited header. Although the sentinel is no longer stringified, the handshake still sends the credential despite the explicit omission; handle Omit in this layered source case by deleting any case-insensitive existing header, as the extra_headers path already does.

Useful? React with 👍 / 👎.

sylvesterkaczmarek · 2026-08-20T09:00:02Z

Addressed. I moved the callable-key refresh/regression from #4537 into this PR, updated the existing STT connection doubles with the client routing/query/header attributes, and centralized the OpenAI-client WebSocket URL/query/header/credential normalization so Responses WebSocket and streamed STT share the same helper while keeping their endpoint-specific suffixes and fixed parameters at the call sites.

sylvesterkaczmarek added 3 commits August 20, 2026 02:19

fix(voice): honor OpenAI client config for streamed STT

2a89812

test(voice): cover streamed STT client configuration

fff641c

test(voice): avoid assigning client properties

0d40f22

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread src/agents/voice/models/openai_stt.py Outdated

Comment thread src/agents/voice/models/openai_stt.py Outdated

sylvesterkaczmarek added 2 commits August 20, 2026 02:43

test(voice): cover client query and omitted headers

9a18176

fix(voice): honor client query and omission sentinels

8b6b1a3

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

Comment thread src/agents/voice/models/openai_stt.py Outdated

Comment thread src/agents/voice/models/openai_stt.py Outdated

seratch added the feature:voice label Aug 20, 2026

seratch requested changes Aug 20, 2026

View reviewed changes

seratch mentioned this pull request Aug 20, 2026

fix(voice): refresh callable API keys before streamed STT #4537

Closed

sylvesterkaczmarek added 5 commits August 20, 2026 09:29

fix(voice): refresh client auth before streamed STT handshake

a0b7ac0

test(voice): cover streamed STT API key refresh

86d59ef

test(voice): give streamed STT client doubles routing metadata

941ebc9

refactor(models): share OpenAI websocket client normalization

d7c5eae

refactor(voice): use shared OpenAI websocket normalization

bcc8d57

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

sylvesterkaczmarek added 3 commits August 20, 2026 09:42

refactor(models): use shared OpenAI websocket normalization

f175739

chore(voice): restore final newline

832db7e

chore(voice): restore test file newline

101108b

chatgpt-codex-connector Bot reviewed Aug 20, 2026

View reviewed changes

Navigation Menu

Uh oh!

fix(voice): honor client config for streamed STT - #4532

fix(voice): honor client config for streamed STT#4532
sylvesterkaczmarek wants to merge 13 commits into
openai:mainfrom
sylvesterkaczmarek:fix/stt-websocket-client-config

sylvesterkaczmarek commented Aug 20, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Aug 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

seratch left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 20, 2026

Uh oh!

sylvesterkaczmarek commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		def _is_openai_omitted_value(value: Any) -> bool:
		return isinstance(value, Omit \| NotGiven)

Uh oh!

Conversation

sylvesterkaczmarek commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Fix

Test plan

Risk

Issue number

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Aug 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Aug 20, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

seratch left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

sylvesterkaczmarek commented Aug 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sylvesterkaczmarek commented Aug 20, 2026 •

edited

Loading