fix: percent-encode spaces in request path URLs - #887
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
HttpRequest.url()encode spaces in path segments as%20instead of+, matching URL path semantics and the URL actually constructed by the OkHttp transport.Fixes #886.
Problem
HttpRequest.url()currently usesURLEncoderfor both path segments and query parameters.For query parameters, form encoding is appropriate and a space becomes
+.For path segments, however,
+is a literal plus character. A request containing:.addPathSegment("user name")currently renders as:
The OkHttp transport itself constructs the request with
HttpUrl.Builder.addPathSegment, so the actual wire URL uses:LoggingHttpClientprintsrequest.url(), which means SDK logs can show a different request target from the one actually sent.Fix
Keep the existing
URLEncoderbehavior for query components, but normalize the encoded path-segment space representation:A literal plus remains unambiguous because
URLEncoderalready encodes it as%2Bbefore the replacement is applied.Regression coverage
Updated
HttpRequestTestto verify:%20;+path character renders as%2B;hello+world.Validation
mainatcf942a40074291290634321ad9fe21e514030b4c;HttpRequest.kt;Full repository validation is left to GitHub Actions.
Risk
Low. This changes only the diagnostic/string rendering of path-segment spaces. Query encoding and transport request construction are unchanged.