fix: always close retry sleeper after delegate failure - #893
Open
sylvesterkaczmarek wants to merge 2 commits into
Open
fix: always close retry sleeper after delegate failure#893sylvesterkaczmarek wants to merge 2 commits into
sylvesterkaczmarek wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure
RetryingHttpClient.close()always attempts to close its ownedSleeper, even when closing the delegateHttpClientthrows.Fixes #890.
Problem
RetryingHttpClientowns both its transport and sleeper, but currently closes them sequentially:If
httpClient.close()throws, sleeper cleanup is skipped entirely.The default sleeper owns a
Timer, and custom sleepers can own other resources, so a transport cleanup failure can cause a second independent resource leak.Fix
Mirror the failure-preserving cleanup pattern already used by
AuthenticatingHttpClient:No retry execution behavior is changed.
Regression coverage
Added focused tests verifying:
Validation
mainatcf942a40074291290634321ad9fe21e514030b4c;RetryingHttpClient.kt;Full repository validation is left to GitHub Actions.
Risk
Low. Successful close behavior is unchanged. The change only guarantees that both owned cleanup paths are attempted when one fails.