build(deps): bump com.gradleup.shadow from 8.3.8 to 9.6.1 in /openai-java-proguard-test - #904
Conversation
Bumps com.gradleup.shadow from 8.3.8 to 9.6.1. --- updated-dependencies: - dependency-name: com.gradleup.shadow dependency-version: 9.6.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
OkTest Summary❌ Failed for Java SDK PR #904. SDK merge ( |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abda53b330
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| plugins { | ||
| id("openai.kotlin") | ||
| id("com.gradleup.shadow") version "8.3.8" | ||
| id("com.gradleup.shadow") version "9.6.1" |
There was a problem hiding this comment.
Shadow 9.6.1 does not support the repository's Gradle 8.12 wrapper; this Shadow release line requires Gradle 9. Because settings.gradle.kts includes every openai-java* project, normal build and test invocations configure this project and fail while applying the plugin, before the ProGuard tests can run. Keep Shadow on a Gradle-8-compatible release or upgrade and validate the wrapper in the same change.
AGENTS.md reference: AGENTS.md:L24-L26
Useful? React with 👍 / 👎.
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Overview
This changes the ProGuard/R8 test fixture from Shadow 8.3.8 to 9.6.1. The fat JAR produced by this plugin is a required input to both shrinker compatibility tests, so plugin configuration and archive semantics must remain compatible with the repository Gradle wrapper.
Confirmed Findings
- [High] Shadow 9.6.1 is incompatible with Gradle 8.12
- Location: openai-java-proguard-test/build.gradle.kts:3; wrapper remains
gradle/wrapper/gradle-wrapper.properties:3. - Why: Shadow 9.5+ requires Gradle 9.2+, but this repository is pinned to Gradle 8.12. Exact-head CI fails during configuration with the missing
AdhocComponentWithVariants.addVariantsFromConfiguration(Provider, Action)API, so build, test, API, and runtime jobs cannot run. Failed CI - Suggested fix: Keep 8.3.8 or choose a release compatible with Gradle 8.12. Treat 9.6.1 as part of a separately reviewed Gradle 9.2+ migration, including a fat-JAR output comparison for Shadow 9 breaking changes.
- Location: openai-java-proguard-test/build.gradle.kts:3; wrapper remains
Rejected Findings
None.
Residual Risks
None beyond the confirmed build blocker. Requesting changes; this PR must not merge in its current form.
1 participant
Bumps com.gradleup.shadow from 8.3.8 to 9.6.1.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)