Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repositories {
}

dependencies {
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:1.9.20")
implementation("org.jetbrains.kotlin:kotlin-gradle-plugin:2.4.10")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the compiler compatible with the pinned language level

Kotlin 2.4.10 no longer supports the Kotlin 1.8 language/API level, but the shared openai.kotlin convention still sets both languageVersion and apiVersion to KOTLIN_1_8 in buildSrc/src/main/kotlin/openai.kotlin.gradle.kts. Consequently, compiling any SDK module that applies this convention fails with an unsupported language-version error; either retain a compatible compiler or update and validate the language/API compatibility settings as part of this upgrade.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Align the buildSrc compiler with the plugin dependency

The buildSrc project still applies kotlin("jvm") version "1.9.20" on line 3, while this dependency puts Kotlin Gradle Plugin 2.4.10 classes on its compilation classpath. The Kotlin 1.9 compiler cannot consume the newer Kotlin metadata used by those classes, including the Gradle DSL types imported by the convention plugins, so buildSrc compilation fails before the SDK modules are configured. Upgrade both declarations together as required by SECURITY.md, or leave both on 1.9.20.

Useful? React with 👍 / 👎.

implementation("com.vanniktech:gradle-maven-publish-plugin:0.28.0")

testImplementation(kotlin("test"))
Expand Down
Loading