build(deps): bump com.vanniktech:gradle-maven-publish-plugin in / - #910
build(deps): bump com.vanniktech:gradle-maven-publish-plugin in /#910dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [com.vanniktech:gradle-maven-publish-plugin](https://github.com/vanniktech/gradle-maven-publish-plugin) in `/` from 0.28.0 to 0.37.0. Updates `com.vanniktech:gradle-maven-publish-plugin` from 0.28.0 to 0.37.0 - [Release notes](https://github.com/vanniktech/gradle-maven-publish-plugin/releases) - [Changelog](https://github.com/vanniktech/gradle-maven-publish-plugin/blob/main/CHANGELOG.md) - [Commits](vanniktech/gradle-maven-publish-plugin@0.28.0...0.37.0) --- updated-dependencies: - dependency-name: com.vanniktech:gradle-maven-publish-plugin dependency-version: 0.37.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gradle ... Signed-off-by: dependabot[bot] <support@github.com>
OkTest Summary❌ Failed for Java SDK PR #910. SDK merge ( |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9918710d41
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| `kotlin-dsl` | ||
| kotlin("jvm") version "1.9.20" | ||
| id("com.vanniktech.maven.publish") version "0.28.0" | ||
| id("com.vanniktech.maven.publish") version "0.37.0" |
There was a problem hiding this comment.
Align the plugin upgrade with its Gradle 9 minimum
The checked-in wrapper still uses Gradle 8.12 (gradle/wrapper/gradle-wrapper.properties), but version 0.37.0 declares Gradle 9.0 as its minimum supported version. Because this plugin is applied while configuring buildSrc, every CI, local build, and release invocation using ./gradlew loads an unsupported plugin before executing tasks; upgrade the wrapper and other required build-tool versions together, or retain a plugin release compatible with Gradle 8.12.
AGENTS.md reference: AGENTS.md:L24-L26
Useful? React with 👍 / 👎.
| `kotlin-dsl` | ||
| kotlin("jvm") version "1.9.20" | ||
| id("com.vanniktech.maven.publish") version "0.28.0" | ||
| id("com.vanniktech.maven.publish") version "0.37.0" |
There was a problem hiding this comment.
Migrate Dokka out of V1 mode before upgrading
Version 0.36 and later removed support for Dokka V1, while this repository deliberately sets org.jetbrains.dokka.experimental.gradle.pluginMode=V1Enabled and its publication convention requests JavadocJar.Dokka("dokkaJavadoc") from that V1 task graph. Even after addressing the Gradle/toolchain minimum, the published modules therefore cannot use this plugin version to produce their expected Javadoc artifacts; migrate the documentation pipeline to Dokka V2 with publication coverage, or retain a pre-0.36 plugin release.
AGENTS.md reference: AGENTS.md:L31-L35
Useful? React with 👍 / 👎.
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Overview
This updates both buildSrc references to the Vanniktech Maven Publish plugin from 0.28.0 to 0.37.0. The plugin is foundational build logic used by every published SDK module.
Confirmed Findings
- [High] Version 0.37.0 is incompatible with both the current Gradle and Kotlin toolchains
- Location: buildSrc/build.gradle.kts:4,14
- Why: Upstream declares Gradle 9.0+ and Kotlin Gradle Plugin 2.2+ minima, while this head uses Gradle 8.12 and KGP 1.9.20. Exact-head CI fails while applying
MavenPublishBasePlugin, before any build, test, compatibility, or release task can run. Failed CI - Suggested fix: Retain 0.28.0 or separately review a release whose declared minima fit Gradle 8.12/KGP 1.9.20. Treat 0.37.0 as a coordinated Gradle/Kotlin/Dokka publishing migration.
Rejected Findings
None.
Residual Risks
None beyond the confirmed configuration blocker. Requesting changes; this PR must not merge in its current form.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Bumps com.vanniktech:gradle-maven-publish-plugin in
/from 0.28.0 to 0.37.0.Updates
com.vanniktech:gradle-maven-publish-pluginfrom 0.28.0 to 0.37.0Release notes
Sourced from com.vanniktech:gradle-maven-publish-plugin's releases.
... (truncated)
Changelog
Sourced from com.vanniktech:gradle-maven-publish-plugin's changelog.
... (truncated)
Commits
7017e3denable feature preview (#1381)05f6b6euse 0.37.0-rc1 (#1380)0167c9cChangelog for 0.37.0 (#1379)b652eb3Update dependency java to v26 (#1353)a9f70b3Update dependency com.freeletics.gradle:scripts-formatting-jvm to v0.37.0 (#1...541cf8fLog deployment id and publishing type after Central Portal upload (#1354)d4873e5Update slf4j monorepo to v2 (#1365)42baf9dUpdate android.gradle (#1335)2de1978Update Gradle (#1362)6f03e46Update kotlin monorepo to v2.4.0 (#1352)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions