test: move model regressions out of generated files - #920
Merged
Conversation
apcha-oai
added
the
custom-code-burndown
Contributor
Castiron custom code✅ No new custom-code files detected. 59 mixed files remain; 0 existing customizations changed; 2 customizations removed. Compared
59 existing customizations unchanged
19 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 32429696757 --repo openai/openai-java \
--name castiron-custom-code-32429696757-1 --dir /tmp/castiron-custom-code-32429696757-1
git apply --stat /tmp/castiron-custom-code-32429696757-1/custom-code.patch
cat /tmp/castiron-custom-code-32429696757-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin ca9c11dd90be5b10b67797a0af6e575ce776bb6a fc416244ba5893e4eafa8588c5732c7dd93598db
python3 scripts/castiron/custom_code_report.py report \
--base ca9c11dd90be5b10b67797a0af6e575ce776bb6a \
--head fc416244ba5893e4eafa8588c5732c7dd93598db --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-fc416244ba58
cat /tmp/castiron-custom-code-fc416244ba58/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
apcha-oai
marked this pull request as ready for review
August 20, 2026 23:41
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
jbeckwith-oai
approved these changes
Aug 20, 2026
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
Contributor
There was a problem hiding this comment.
Verified all three existing model regression tests and their assertions move unchanged into already-discovered handwritten JUnit classes; fixtures, setup, test coverage, production code, and public API are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move three handwritten regression tests into the existing SDK-owned test classes so the generated test files can match their verified generated snapshot. No assertions, test bodies, or existing destination parameterization are removed or changed:
ChatCompletionCreateParamsTest.structuredOutputsBuilder→StructuredChatCompletionCreateParamsTest.structuredOutputsBuilder.EmbeddingTest.create_setThenAdd→EmbeddingValueTest.create_setThenAdd.EmbeddingTest.create_addThenSet→EmbeddingValueTest.create_addThenSet.Production code, public API, generation metadata, and API-reference artifacts are unchanged. The custom-code report moves from 61 to 59 mixed files, with two customizations removed and all 59 others unchanged.
Test Plan
Automated