feat: clarify publisher state and discovery labels - #2949
Conversation
|
@giodl73-repo is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel. A member of the Team first needs to authorize it. |
8c4f7a9 to
e9f7342
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
e9f7342 to
dab68ea
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: needs real behavior proof before merge. Reviewed July 22, 2026, 1:32 AM ET / 05:32 UTC. Summary Reproducibility: yes. for the review finding: a publisher with at least 20 eligible-role membership rows whose scanned users are all deleted or deactivated reaches the fallback that returns claimed. No supplied live setup proves the intended API/UI behavior after the proposed change. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Copy recommended automerge instructionNext step before merge
Maintainer decision needed
Security Review findings
Review detailsBest possible solution: Confirm the publisher-state contract, require claimState to be based on an observed active eligible member, add focused regression coverage for saturated inactive membership, and attach redacted live API plus browser proof showing active, inactive, official, and non-official publisher cases. Do we have a high-confidence way to reproduce the issue? Yes for the review finding: a publisher with at least 20 eligible-role membership rows whose scanned users are all deleted or deactivated reaches the fallback that returns claimed. No supplied live setup proves the intended API/UI behavior after the proposed change. Is this the best way to solve the issue? No. The separation of official state from feed or install trust is directionally sound, but returning claimed from a saturated scan without an observed active member is not a reliable implementation of the proposed state contract. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a9775fc39b10. Label changesLabel justifications:
Evidence reviewedSecurity concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (8 earlier review cycles)
|
dab68ea to
02f37d0
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
02f37d0 to
8397af9
Compare
|
🦞🧹 I asked ClawSweeper to review this item again. |
8397af9 to
1820c79
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
1820c79 to
addff1f
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
dd684f0 to
a9e7c22
Compare
|
This pull request has been automatically marked as stale due to inactivity. |
|
Closing due to inactivity. |
Summary
Verifiedwording toOfficialOfficial publisher,Public profile, andPublic cataloglabels where supported by existing factsReview unit
This PR combines publisher-state facts with the profile/discovery labels that consume existing publisher facts. It does not add following, feed transport, scan authority, install eligibility, or OpenClaw registry decisions.
Trust boundary
Publisher official state is a ClawHub identity fact. It does not imply that a feed is signed, an artifact is reviewed or scanned, or an install is locally approved.
Validation
git diff --check