fix: settings page fails to load when the deployed backend predates the listMine args change

[mattmillerai]

What Problem This Solves

Signed-in users currently get the global error boundary on /settings:

Something went wrong
[CONVEX Q(publishers:listMine)] Server Error Called by client

#3073 made the settings route pass { includePublishedItems: false } to publishers:listMine, but Convex validators reject unknown arguments. Whenever the deployed web app is newer than the deployed Convex backend — true in production right now — the whole settings route error-boundaries for every signed-in user.

Verifiable from anywhere (unauthenticated):

# what the settings route sends today → error on the live backend
curl -s -X POST https://wry-manatee-359.convex.cloud/api/query \
  -H 'Content-Type: application/json' \
  -d '{"path":"publishers:listMine","args":{"includePublishedItems":false},"format":"json"}'
# → {"status":"error","errorMessage":"[Request ID: …] Server Error"}

# legacy args → success (deployed validator still has args: {})
curl -s -X POST https://wry-manatee-359.convex.cloud/api/query \
  -H 'Content-Type: application/json' \
  -d '{"path":"publishers:listMine","args":{},"format":"json"}'
# → {"status":"success","value":[]}

What This Changes

The settings route omits the argument and passes {}, which both backend generations accept — the new backend defaults includePublishedItems to true, so rendering is unchanged and the page works regardless of deploy order. A brief comment marks the rollout hazard. The lightweight-list optimization from #3073 can be reintroduced once the new validator is verifiably live in production.

Even after the backend catches up, this keeps /settings resilient to the frontend-ahead-of-backend deploy window that any future arg addition reopens.

Tests: src/routes/-settings.test.tsx updated (24/24 passing); biome clean.

Related: #3064

[vercel]

@mattmillerai is attempting to deploy a commit to the OpenClaw Foundation Team on Vercel.

A member of the Team first needs to authorize it.

[clawsweeper]

Codex review: needs real behavior proof before merge. Reviewed July 17, 2026, 10:47 AM ET / 14:47 UTC.

Summary
The PR changes the Settings publisher-membership query from { includePublishedItems: false } to {} and updates the corresponding component-test expectation.

Reproducibility: yes. at high confidence from the API contract and live before-fix transcript: a frontend sending the new argument to an older Convex validator receives a server error. The after-fix signed-in browser path was not demonstrated.

Review metrics: 2 noteworthy metrics.

• Patch scope: 2 files; 6 added, 2 removed. The branch is a narrowly scoped runtime-call rollback plus one focused test expectation.
• Behavioral calls changed: 1 query argument shape changed. The user-facing fix depends on restoring compatibility for one Settings query across backend generations.

Merge readiness
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🐚 platinum hermit
Result: blocked until real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

• [P1] Add redacted after-fix browser or live runtime evidence if the PR remains a merge candidate.
• Identify the exact current-main implementation commit and release status so the redundant PR can be closed safely.

Proof guidance:

• [P1] Needs real behavior proof before merge: The live curl transcript proves the pre-fix incompatibility, but the contributor has not shown an after-fix signed-in browser or live runtime run of /settings against the older backend; proof should be redacted, added to the PR body, and followed by automatic re-review or a maintainer @clawsweeper re-review comment. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

• [P1] The PR appears redundant with current main, but auto-closing requires the exact implementation commit, timestamp, and release-or-main-only provenance.
• [P1] If the PR remains a merge candidate, contributor after-fix real-browser proof is still absent despite the narrow and plausible source change.

Maintainer options:

1. Decide the mitigation before merge
   Identify the commit that changed current main to pass {} and close this PR as implemented if its timestamp and release status are confirmed; otherwise require a redacted signed-in /settings run against the older backend before merge.
2. Pause or close
   Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

• [P1] A maintainer should identify the exact commit already implementing {} on current main and its release status, then close as redundant or retain the proof gate if merge is still considered.

Security
Cleared: The patch only changes a query argument shape and test expectation, with no permissions, secrets, dependencies, workflows, package execution, or trust-boundary changes.

Review details

Best possible solution:

Identify the commit that changed current main to pass {} and close this PR as implemented if its timestamp and release status are confirmed; otherwise require a redacted signed-in /settings run against the older backend before merge.

Do we have a high-confidence way to reproduce the issue?

Yes at high confidence from the API contract and live before-fix transcript: a frontend sending the new argument to an older Convex validator receives a server error. The after-fix signed-in browser path was not demonstrated.

Is this the best way to solve the issue?

Yes. Omitting the optional argument is the narrowest compatibility-preserving rollback because both backend generations accept {}, and current main already uses that shape.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 088cb3275c2a.

Label changes

Label justifications:

• P0: The reported deploy-skew state sends every signed-in Settings visit to the global error boundary with no in-product recovery path.
• rating: 🦪 silver shellfish: Overall readiness is 🦪 silver shellfish; proof is 🦪 silver shellfish and patch quality is 🐚 platinum hermit.
• status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: The live curl transcript proves the pre-fix incompatibility, but the contributor has not shown an after-fix signed-in browser or live runtime run of /settings against the older backend; proof should be redacted, added to the PR body, and followed by automatic re-review or a maintainer @clawsweeper re-review comment. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Evidence reviewed

What I checked:

• Current-main behavior: At current main, the Settings route calls api.publishers.listMine with {} when account-scoped queries load, so the central compatibility behavior is already present. (src/routes/settings.tsx:271, 088cb3275c2a)
• Regression provenance: Merged pull request perf(publishers): reduce profile and catalog read amplification (#3064 / #2925) #3073 introduced the includePublishedItems argument as part of the publisher-read optimization, matching the regression described here. (src/routes/settings.tsx:269, 307f11f5b802)
• Proposed patch: The branch replaces the new argument with empty arguments and changes the focused test assertion, without unrelated code, dependency, workflow, or generated-file changes. (src/routes/settings.tsx:269, 21aa30a8cfcd)
• Proof gap: The PR body includes live before-fix Convex API responses, but no after-fix signed-in browser or live runtime evidence showing /settings loading against the older backend. (21aa30a8cfcd)
• Release provenance unresolved: The supplied latest release is v0.23.1 at a230d96, but the exact current-main fix commit was unavailable, so release inclusion cannot be established. (CHANGELOG.md, a230d962db64)

Likely related people:

• vyctorbrzezowski: Authored the merged publisher-read optimization that added the listMine argument and touched the Settings query and related backend behavior. (role: introduced affected behavior; confidence: high; commits: 307f11f5b802; files: src/routes/settings.tsx, src/routes/-settings.test.tsx, convex/publishers.ts)

What the crustacean ranks mean

• 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
• 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
• 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
• 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
• 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
• 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
• 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Review history (2 earlier review cycles)

• reviewed 2026-07-16T12:18:54.079Z sha 21aa30a :: needs real behavior proof before merge. :: none
• reviewed 2026-07-17T11:35:14.555Z sha 21aa30a :: needs real behavior proof before merge. :: none

[clawsweeper]

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix: settings page fails to load when the deployed backend predates the listMine args change This is item 1/1 in the current shard. Shard 15/20.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

[Patrick-Erichsen]

Resolved by the production Convex rollout on July 14, 2026: the deployed publishers:listMine validator now accepts includePublishedItems, and live production accepts both {} and { includePublishedItems: false }. Current main intentionally retains the bounded-read argument, so this compatibility rollback is now obsolete. Thanks for catching the real deploy-skew window.