fix: scan historical legacy package paths - #3337
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production symptom and root cause
The notification-disabled beta scan repeatedly stopped on
s2-space-agent-os@2.0.0because its historical release containss2-os-core:requirements.txtand a mojibake filename with control-code bytes. Both predate portable filename validation. The protected scan artifact endpoint rebuilt this release through the modern strict ZIP builder and threw before returning bytes.Repro workflow: https://github.com/openclaw/clawhub/actions/runs/30603891909
Provenance: strict validation entered the shared builder in #3090. This fix preserves that contract and adds a scan-only legacy projection at the failing endpoint.
Validation
bunx vitest run convex/packageInspectorHttp.test.ts convex/lib/skillZip.test.ts— 26 passedbun run ci:unit— 5,831 passed, 2 skippedbun run ci:types-build— passedbun run ci:packages— passedbun run ci:static— passed from a clean clone (the source worktree intentionally preserves unrelated untracked artifacts).agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main --stream-engine-output— clean, no accepted/actionable findings