Handle delayed proof nudge schedules#249
Conversation
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Codex review: needs maintainer review before merge. Reviewed June 3, 2026, 9:32 AM ET / 13:32 UTC. Summary Reproducibility: yes. Current main's workflow checks the actual Central hour, and the PR body's delayed 06:35/07:32 CDT starts would both fall outside Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow guard update with the paired docs/test change, then confirm the first scheduled dry-run report shows only the seasonal 5 AM Central candidate continues. Do we have a high-confidence way to reproduce the issue? Yes. Current main's workflow checks the actual Central hour, and the PR body's delayed 06:35/07:32 CDT starts would both fall outside Is this the best way to solve the issue? Yes. Using the triggering cron string plus the current Central zone abbreviation is a narrow fix that preserves the existing two-cron DST design while removing sensitivity to GitHub queue delay. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 9c50a95427c2. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
Root cause
The 5 AM Central guard added in #246 checked the runner's actual local hour. GitHub started today's scheduled runs late, so both candidates skipped even though the feature was enabled:
Real behavior proof
Local proof for the new decision rule, including today's delayed starts:
This keeps exactly one seasonal candidate live even if GitHub queues the run late.
Validation