docs(localization): clarify progressive slice delivery - #49
docs(localization): clarify progressive slice delivery#49giodl73-repo wants to merge 15 commits into
Conversation
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Codex review: needs real behavior proof before merge. Reviewed August 1, 2026, 11:20 AM ET / 15:20 UTC. ClawSweeper reviewWhat this changesThe branch rewrites RFC 0024 and five localization sidecars to describe progressive 15-surface delivery, a 315-cell completion target, and direct in-place catalog refreshes for ready same-repository pull requests. Merge readinessKeep this PR open for human review: it changes the accepted localization publication boundary from generated pull requests to credentialed automation writing directly to qualifying contributor branches. That is a security and product-policy amendment, not a clarification. Likely related people: giodl73-repo (high-confidence RFC history) and Patrick Erichsen (medium-confidence named implementation-stack reviewer). Priority: P2 Review scores
Verification
How this fits togetherRFC 0024 defines how OpenClaw detects English-source drift, produces translated catalogs, validates them, and lets each product surface render localized text. Its publication workflow is intended to guide later implementation in the OpenClaw repository, where trusted automation and human review control generated catalogs. flowchart TB
Source[English source pull request] --> Detect[Credential-free drift detection]
Detect --> Decision[Choose trusted refresh path]
Decision --> Generated[Generated translation pull request]
Decision --> InPlace[Proposed direct branch update]
Generated --> Review[Validation and human review]
InPlace --> Review
Review --> Ship[Owner ships catalog]
Ship --> Render[Surface renders localized text]
Decision needed
Why: Current main explicitly chooses the generated-pull-request boundary. Deciding where credentialed automation may write is a trust, review, and product-policy choice that cannot be resolved by documentation edits alone. Before merge
Findings
Agent review detailsSecurityNeeds attention: The diff is Markdown-only but proposes a security-sensitive change to where credentialed translation automation writes generated artifacts. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the accepted generated-pull-request publication model, or land a narrowly approved RFC amendment only after the relevant OpenClaw workflow and security owners document and approve direct-write authorization, token scope, exact-head handling, rollback, and audit evidence. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a documentation PR proposing a workflow and trust-boundary policy, not a report of broken runtime behavior. Current main clearly documents the conflicting accepted publication path. Is this the best way to solve the issue? No: presenting direct branch writes as a clarification conflicts with current main’s accepted generated-pull-request contract. The narrow maintainable path is to retain that contract unless owners approve a specific amendment with implementation evidence. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against af708f0ddb6f. LabelsLabel changes:
Label justifications:
EvidenceSecurity concerns:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (8 earlier review cycles)
|
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Pre-merge cleanup is complete at exact head 55b382c: the system diagram is now a vertical 1. Own -> 2. Automate -> 3. Ship summary, and the PR body includes after-change link, slice-ID, diff, Mermaid-render, and semantic-review evidence. Patrick remains requested for the explicit mandatory slice-completion decision. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
The system overview now uses only searchable implementation names from openclaw/openclaw: localization/surfaces.json, localization/catalogs.json, the localization-catalogs CI job, Localization Catalog Refresh, @openclaw/localization-core, and LocalizationContext. RFC planning IDs are absent from the overview and diagram. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Added an exact-head, source-accurate end-to-end example at
Validated the values and registry entries directly against openclaw#112784 / #112801. GitHub Markdown recognizes both Mermaid blocks in the RFC and PR body. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Simplified at exact head The main RFC is now 1,677 words (down from 7,431) and leads with the real wizard string. Reference-level mechanics remain in the normative sidecars. The product target is now unambiguous: English source + 21 translation targets across 15 required surfaces = 315 target cells, and only 315/315 is product-complete. A platform constraint may explain a blocker but no longer reduces the completion target to 313. Validated: clean diff, 6/6 relative links, 47/47 unique slice IDs, both RFC Mermaid blocks recognized, and the example values/registrations asserted against openclaw#112784 and #112801. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Sidecar clarity pass at exact head
Validated 15/15 row-ID parity against @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Made the exemplar event-specific at exact head
This now matches #112784 exactly: PR detection is warning-only for ordinary source drift, generated-path changes run the strict check, and translation/provider/publisher credentials exist only in the trusted post-merge workflow. The implementation plan, coverage state machine, registry, RFC, and PR body use the same description. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Applied a seven-lens
The panel found no remaining architecture contradiction after these fixes. Main RFC remains under 2,000 words, all 15 product surfaces remain visible, both RFC Mermaid blocks and the PR-body Mermaid block render, and claims remain source-backed by #112784/#112801. This role review does not replace Patrick's current-head decision. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Follows accepted RFC #42.
What this clarifies
One string, end to end
The workflow executes generator code from protected
main; the PR registry and English catalogs are validated data only. It never executes PR scripts, actions, dependencies, or hooks with provider credentials. Before pushing, it rechecks open/ready/same-repository/base/head state and uses an exact-head lease. Automation does not approve or merge its output.Delivery
Each owner slice enrolls one bounded surface in the shared gate and refresh workflow, or proves its existing owner pipeline conforms. The 47 projected slices remain grouped into 16 delivery packages toward the September 1, 2026 completion decision. Live delivery stays in openclaw#113105.
Core exemplar: openclaw#112784. Surface registration: openclaw#112801.
Review decision
Project direction and progressive owner onboarding were aligned with Patrick and Vince in Discord. Patrick remains the primary implementation-stack reviewer; semantic, security, platform, and publication owners still review their boundaries.
Validation
Exact head:
0e19881be5a456bfcbf29a81bcc87dbcaf471b08AI-assisted: yes. I reviewed the wording and validation evidence.