Skip to content

Refactor: Move nwp module to scripts/nwp_data directory - #117

Open
ram-from-tvl wants to merge 3 commits into
openclimatefix:mainfrom
ram-from-tvl:refactor/rename-nwp-to-scripts-nwp-data
Open

Refactor: Move nwp module to scripts/nwp_data directory#117
ram-from-tvl wants to merge 3 commits into
openclimatefix:mainfrom
ram-from-tvl:refactor/rename-nwp-to-scripts-nwp-data

Conversation

@ram-from-tvl

@ram-from-tvl ram-from-tvl commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Pull Request

Description

Reorganize NWP module by moving it from src/open_data_pvnet/nwp to scripts.

Fixes #112

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have checked my code and corrected any misspellings
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copilot AI review requested due to automatic review settings January 9, 2026 19:08
@ram-from-tvl

Copy link
Copy Markdown
Contributor Author

Hi @peterdudfield
Please let me know if the changes look good to you.
Thank you!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@@ -13,8 +13,8 @@
from typing import List, Tuple

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this main file should also move in scripts/nwp_data

@ram-from-tvl

Copy link
Copy Markdown
Contributor Author

Hi @peterdudfield
I have made the changes. Please let me know if we are good to go.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename src/open_data_pvnet/nwp_data to scripts/nwp_data dir

3 participants