feat: add trial check and don't allow forecast access - #365
Open
suvanbanerjee wants to merge 5 commits into
Open
feat: add trial check and don't allow forecast access#365suvanbanerjee wants to merge 5 commits into
suvanbanerjee wants to merge 5 commits into
Conversation
suvanbanerjee
changed the title
suvanbanerjee
commented
Aug 13, 2026
Comment on lines
+14
to
15
| #TODO: verify this string with brad | ||
| cache_dependent_scopes = ["read:intraday"] |
Member
Author
There was a problem hiding this comment.
@braddf I think it should be read:uk-intraday? as in thwe time utils we are checking for
if "read:uk-intraday" in permissions:
return min(end_datetime_utc, intraday_max_allowed)
suvanbanerjee
commented
Aug 13, 2026
Comment on lines
+19
to
+21
| No claim at all (paid/non-trial user) is treated the same as an unexpired | ||
| trial: both mean "don't clamp." Only a claim that has actually passed | ||
| counts as expired. |
Member
Author
There was a problem hiding this comment.
@braddf I’ve assumed that if a user does not have the trial_ends_at attribute, they are a paid user. Is this assumption correct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Restrict free trail expired users to only see past values and block future forecast
Fixes #352
How Has This Been Tested?
UI after api blocking
Checklist: