replace fsspec with obstore for faster object storage access - #64
Open
ram-from-tvl wants to merge 3 commits into
Open
ram-from-tvl wants to merge 3 commits into
ram-from-tvl wants to merge 3 commits into
Conversation
- Resolved conflicts between obstore implementation and new upstream features - Kept obstore integration for S3 and local filesystem access - Added support for GCS via gcsfs (from upstream) - Added icechunk support for versioned zarr stores (from upstream) - Maintained performance improvements from obstore while preserving all new functionality
Contributor
Author
|
Hi @jacobbieker |
jacobbieker
requested changes
Sep 13, 2025
jacobbieker
left a comment
Contributor
There was a problem hiding this comment.
Looks nice! Will want to have @devsjc have a look before merging it too, but yeah, just one more change to remove fsspec from the codebase for GCP as well please.
- Replace gcsfs with obstore FsspecStore for GCS - Remove gcsfs dependency as it's no longer needed - All filesystem types (local, S3, GCS) now use obstore - Addresses maintainer feedback in PR review
Contributor
Author
|
Hi @jacobbieker |
jacobbieker
self-requested a review
September 15, 2025 09:15
jacobbieker
approved these changes
Sep 15, 2025
jacobbieker
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Will wait for @devsjc to check though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR replaces fsspec with obstore for faster object storage access, providing significant performance improvements for reading/writing from cloud storage backends.
Changes made:
fsspecands3fsimports withobstore.fsspec.FsspecStoreinstorage.pyget_fs()function to create obstore-backed filesystems while maintaining full API compatibilityobstore >= 0.2.0dependency topyproject.tomlFixes #47
How Has This Been Tested?
Testing performed:
download_eumetsat.pyandrun.pyTest configuration:
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: