fix(resources): validate required executables - #188
Merged
Merged
Conversation
Emin017
requested changes
Aug 21, 2026
Emin017
requested changes
Aug 25, 2026
Emin017
left a comment
Member
There was a problem hiding this comment.
The previous canonical-policy duplication has been fixed by the new focused module. One blocking marker-type gap remains: non-executable markers still use existence-only validation, so incomplete archives can pass the same staged and installed health boundary this PR is intended to harden.
Emin017
requested changes
Aug 25, 2026
Emin017
left a comment
Member
There was a problem hiding this comment.
The marker-type behavior from the previous review is fixed. One test-quality blocker remains.
Emin017
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is remediation 5 of 6 extracted from the code review follow-up in #182. It addresses incomplete resource health checks found during review of
f5e9af0f536878f804ef51887e5f5ab734388a24.Finding
A resource could be reported as installed when its marker path merely existed. Directories, non-executable files, or incomplete staged archives could therefore pass health checks and fail only when the tool was launched.
Changes
Result
Resource Manager now reports
Installedonly when the required tool entry points are present and usable. Broken replacement archives fail before activation without destroying a working installation.Verification
main.pnpm run checkpassed on this single-fix branch.Installedstate.Review lineage
7ec485ee66e158