Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
=======================================
Coverage 87.13% 87.13%
=======================================
Files 48 48
Lines 1407 1407
Branches 297 297
=======================================
Hits 1226 1226
Misses 168 168
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description:
The current PR extends the Babel configuration to support
.tsduring code transpilation.What was changed:
--extensions '.js,.jsx,.ts,.tsx'to the build command so Babel processes TS files.test.tsfiles in dist (alongside the existing.test.jscleanup)tsconfig.jsonextending@edx/typescript-configfor run test in tsWhat the PR does not do:
Merge checklist:
frontend-platform. This can be done by runningnpm startand opening http://local.openedx.io:8080.module.config.jsfile infrontend-build.fix,feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: