Skip to content

fix: correcting build error#219

Merged
felipemontoya merged 1 commit into
mainfrom
fmo/build-fix
May 9, 2026
Merged

fix: correcting build error#219
felipemontoya merged 1 commit into
mainfrom
fmo/build-fix

Conversation

@felipemontoya
Copy link
Copy Markdown
Member

This error showed up when building the mfe image downstream.

[4](https://github.com/eduNEXT/aiext-azimut-project/actions/runs/25584365364/job/75109876295#step:19:3135)
128.6 ./node_modules/.bin/tsc -p tsconfig.build.json --emitDeclarationOnly
145.8 src/ai-extensions-settings/components/WorkflowsConfigTab.tsx(161,8): error TS2741: Property 'isOverflowVisible' is missing in type '{ children: Element[]; title: any; isOpen: boolean; onClose: () => void; hasCloseButton: true; }' but required in type 'Pick<Props, keyof Props>'.
145.9 make: *** [Makefile:13: build] Error 2

To avoid this ever happening again, I'm also editing the CI to check types.

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @felipemontoya!

This repository is currently maintained by @felipemontoya.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels May 8, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.22%. Comparing base (4d4a1fe) to head (4ea7d52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          68       68           
  Lines        7901     7901           
  Branches      414      414           
=======================================
  Hits         7524     7524           
  Misses        286      286           
  Partials       91       91           
Flag Coverage Δ
unittests 95.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@felipemontoya felipemontoya merged commit bb0cdb5 into main May 9, 2026
10 checks passed
@felipemontoya felipemontoya deleted the fmo/build-fix branch May 9, 2026 00:19
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants