Migrate to pydantic v2 and switch tests to Polyfactory#550
Merged
Conversation
SergioSim
reviewed
Jan 24, 2024
Collaborator
SergioSim
left a comment
SergioSim
left a comment
There was a problem hiding this comment.
This looks amazing 👍
Can't wait to see this merged) have only a few optional minor questions)
Leobouloc
force-pushed
the
structure/tests/pydantic-v2-and-polyfactory
branch
from
00a2614 to
90be668
Compare
Leobouloc
force-pushed
the
structure/tests/pydantic-v2-and-polyfactory
branch
2 times, most recently
from
548bcc5 to
81d37d4
Compare
This was referenced Feb 12, 2024
Closed
wilbrdt
force-pushed
the
structure/tests/pydantic-v2-and-polyfactory
branch
2 times, most recently
from
f4c8287 to
f739ca3
Compare
wilbrdt
requested review from
quitterie-lcs and
wilbrdt
and removed request for
wilbrdt
wilbrdt
force-pushed
the
structure/tests/pydantic-v2-and-polyfactory
branch
2 times, most recently
from
e46e3b3 to
de2d1d9
Compare
wilbrdt
force-pushed
the
structure/tests/pydantic-v2-and-polyfactory
branch
from
de2d1d9 to
8ebdca5
Compare
Migrating to `pydantic` v2 should speed up processing and allow interoperability with projects such as `warren`. This migration makes the hypothesis package used in tests obsolete, which is why we introduce `polyfactory`.
wilbrdt
force-pushed
the
structure/tests/pydantic-v2-and-polyfactory
branch
from
8ebdca5 to
2f25e8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate to pydantic v2 for speed (as suggested: #401) and warren compatibility.
As hypothesis is no longer supported, it was decided to use polyfactory for model generation.