Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Nov 13, 2025

Please review following fix that adds jni exception check after calling java code.

Tested by running test with and without -Xcheck:jni.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371749: New test serviceability/jvmti/events/VMDeath/AllocatingInVMDeath/TestAllocatingInVMDeath.java fails with -Xcheck:jni (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28280/head:pull/28280
$ git checkout pull/28280

Update a local copy of the PR:
$ git checkout pull/28280
$ git pull https://git.openjdk.org/jdk.git pull/28280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28280

View PR using the GUI difftool:
$ git pr show -t 28280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28280.diff

Using Webrev

Link to Webrev Comment

…eath/TestAllocatingInVMDeath.java fails with -Xcheck:jni
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371749: New test serviceability/jvmti/events/VMDeath/AllocatingInVMDeath/TestAllocatingInVMDeath.java fails with -Xcheck:jni

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@lmesnik The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2025
jni->CallStaticObjectMethod(clz, mid);
if (jni->ExceptionOccurred()) {
jni->ExceptionDescribe();
fatal(jni, "Unexpected exception occured in cbVMDeath.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Typo: s/occured/occurred/
Also, this message is confusing. Unexpected exception occurred in Java upcall made from the cbVMDeath.
Maybe something like this: "cbVMDeath: unexpected exception occurred in Java upcall method".

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 13, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review serviceability [email protected]

Development

Successfully merging this pull request may close these issues.

3 participants