Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 13, 2025

Hi all,

I found that FileStore.supportsFileAttributeView("dos") return false, but Files.getFileAttributeView(file, viewClass) return none null, cause test/jdk/java/nio/file/FileStore/Basic.java fails on some linux-aarch64 machines.

This PR add check supportsFileAttributeView before return FileAttributeView in function getFileAttributeView.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371697: FileStore.getFileAttributeView("dos") should return null if unavailable (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28281/head:pull/28281
$ git checkout pull/28281

Update a local copy of the PR:
$ git checkout pull/28281
$ git pull https://git.openjdk.org/jdk.git pull/28281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28281

View PR using the GUI difftool:
$ git pr show -t 28281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28281.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@sendaoYan The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@AlanBateman
Copy link
Contributor

Files.getFileAttributeView returns a FileAttributeView if the file system provider supports it. I don't think we have an implementation bug here, instead I suspect there is a test issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nio [email protected] rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants