8371697: FileStore.getFileAttributeView("dos") should return null if unavailable #28281
+26
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I found that FileStore.supportsFileAttributeView("dos") return false, but Files.getFileAttributeView(file, viewClass) return none null, cause test/jdk/java/nio/file/FileStore/Basic.java fails on some linux-aarch64 machines.
This PR add check supportsFileAttributeView before return FileAttributeView in function getFileAttributeView.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28281/head:pull/28281$ git checkout pull/28281Update a local copy of the PR:
$ git checkout pull/28281$ git pull https://git.openjdk.org/jdk.git pull/28281/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 28281View PR using the GUI difftool:
$ git pr show -t 28281Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28281.diff
Using Webrev
Link to Webrev Comment