Skip to content

Conversation

@tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Nov 13, 2025

Hi all,

please review this change that improves the accuracy of G1CollectedHeap::non_young_occupancy_after_allocation() by considering the free space in the old gen retained region.

Testing: tier1-3, gha

Thanks,
Thomas


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371791: G1: Improve accuracy of G1CollectedHeap::non_young_occupancy_after_allocation() (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28294/head:pull/28294
$ git checkout pull/28294

Update a local copy of the PR:
$ git checkout pull/28294
$ git pull https://git.openjdk.org/jdk.git pull/28294/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28294

View PR using the GUI difftool:
$ git pr show -t 28294

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28294.diff

Using Webrev

Link to Webrev Comment

Hi all,

  please review this change that improves the accuracy of `G1CollectedHeap::non_young_occupancy_after_allocation()` by considering the free space in the old gen retained region.

Testing: tier1-3, gha

Thanks,
  Thomas
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371791: G1: Improve accuracy of G1CollectedHeap::non_young_occupancy_after_allocation()

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • bfc048a: 8371608: Jtreg test jdk/internal/vm/Continuation/Fuzz.java sometimes fails with (fast)debug binaries
  • 8102f43: 8371480: VerifyError after JDK-8369654

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8371791 8371791: G1: Improve accuracy of G1CollectedHeap::non_young_occupancy_after_allocation() Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@tschatzl The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc [email protected] ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

3 participants