Skip to content

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Nov 13, 2025

This fix simplifies the hotspot intrinsics for some platforms and optimizes the key computation for encryption. We can save the genInvRoundKeys computation when we only do encryption.

The micro:org.openjdk.bench.javax.crypto.AESReinit benchmark results are improved by 17% for ppc64 and 26% for x86_64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371820: Further AES performance improvements for key schedule generation (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28299/head:pull/28299
$ git checkout pull/28299

Update a local copy of the PR:
$ git checkout pull/28299
$ git pull https://git.openjdk.org/jdk.git pull/28299/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28299

View PR using the GUI difftool:
$ git pr show -t 28299

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28299.diff

Using Webrev

Link to Webrev Comment

@TheRealMDoerr
Copy link
Contributor Author

@smemery: I've seen your recent improvements and performance measurements. It would be great if you could take a look at this proposal and check the performance results in your environment.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 13, 2025

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@TheRealMDoerr The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 13, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 13, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant