8371607: Remove GCSharedStringsDuringDumpWb.java after JDK-8362561

[Arraying]

Hi all,

JDK-8362561 removed runtime/cds/appcds/javaldr/GCSharedStringsDuringDump.java which was the only place where GCSharedStringsDuringDumpWb.java was used. Therefore, GCSharedStringsDuringDumpWb.java should be cleaned up.

Testing: tiers 1-3 Linux (x64, AArch64), macOS (x64, AArch64), Windows (x64).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371607: Remove GCSharedStringsDuringDumpWb.java after JDK-8362561 (Bug - P4)

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Joel Sikström (@jsikstro - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28300/head:pull/28300
$ git checkout pull/28300

Update a local copy of the PR:
$ git checkout pull/28300
$ git pull https://git.openjdk.org/jdk.git pull/28300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28300

View PR using the GUI difftool:
$ git pr show -t 28300

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28300.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phubner! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Arraying This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371607: Remove GCSharedStringsDuringDumpWb.java after JDK-8362561

Reviewed-by: ayang, jsikstro

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 8690d26: 8268613: jar --validate should check inital entries of a JAR file
• ce1adf6: 8371672: G1: G1YoungGenSizer handling of NewRatio, NewSize and MaxNewSize
• 7738131: 8371642: TestNumberOfContinuousZeros.java fails on PPC64
• ... and 35 more: https://git.openjdk.org/jdk/compare/bfc048aba6391d52c07d9a5146466b47d2f6fed8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @jsikstro) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@Arraying The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (20d6f71a)

[jsikstro]

Thank you for taking care of this!

[Arraying]

Thanks for the reviews, @albertnetymk @jsikstro.
/sponsor

[Arraying]

Good morning to me, I got the command wrong.
/integrate

[openjdk]

@Arraying Only Committers are allowed to sponsor changes.

[openjdk]

@Arraying
Your change (at version 20d6f71) is now ready to be sponsored by a Committer.

[jsikstro]

/sponsor

[openjdk]

Going to push as commit 6385c663dc6ce892c23bc9208e1ffe24fa78ccd7.
Since your change was applied there have been 49 commits pushed to the master branch:

• 44087ea: 8371682: Suppress javac warning from ThreadPoolExecutorSubclassTest.java
• 960987e: 8371991: Build failure in docs for MemoryMXBean
• 8301d99: 8371825: G1: Use more precise filler API in fill_range_with_dead_objects
• ... and 46 more: https://git.openjdk.org/jdk/compare/bfc048aba6391d52c07d9a5146466b47d2f6fed8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jsikstro @Arraying Pushed as commit 6385c66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.