8371689: (fs) CopyMoveHelper.copyToForeignTarget use of sourcePosixView is confusing

[bplb]

In CopyMoveHelper, replace PosixFileAttributeView with a boolean.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8371689: (fs) CopyMoveHelper.copyToForeignTarget use of sourcePosixView is confusing (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28304/head:pull/28304
$ git checkout pull/28304

Update a local copy of the PR:
$ git checkout pull/28304
$ git pull https://git.openjdk.org/jdk.git pull/28304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28304

View PR using the GUI difftool:
$ git pr show -t 28304

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28304.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fe0eedac)

[AlanBateman]

I'm concerned this will add overhead to each copy operation. There shouldn't be any need to use FileStore in this method. If the provider supports the the POSIX view then this method can use it.

[AlanBateman]

So I think the summary is the JBS issue isn't really a bug, it's more than using sourcePosixView instead of boolean is confusing when looking at this code.