8354695: Open source several swing tests batch7#4354
8354695: Open source several swing tests batch7#4354satyenme wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into |
|
@satyenme This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8354695: Open source several swing tests batch7 Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle. Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle (and tests were previously closed source). |
gnu-andrew
left a comment
There was a problem hiding this comment.
Patch verified clean when compared to openjdk/jdk21u-dev#2810 and new tests pass (though status of JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java unclear as Windows only)
|
/approve yes |
|
@gnu-andrew |
|
/integrate |
|
Going to push as commit 2dded17. |
Backporting JDK-8354695: Open source several swing tests batch7. Adds seven javax/swing tests. Ran GHA Sanity Checks and (non-windows) new tests directly. Patch is clean. Backporting for parity with Oracle.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4354/head:pull/4354$ git checkout pull/4354Update a local copy of the PR:
$ git checkout pull/4354$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4354/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4354View PR using the GUI difftool:
$ git pr show -t 4354Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4354.diff
Using Webrev
Link to Webrev Comment