Skip to content

8354695: Open source several swing tests batch7#4354

Closed
satyenme wants to merge 1 commit intoopenjdk:masterfrom
satyenme:8354695
Closed

8354695: Open source several swing tests batch7#4354
satyenme wants to merge 1 commit intoopenjdk:masterfrom
satyenme:8354695

Conversation

@satyenme
Copy link
Copy Markdown

@satyenme satyenme commented Apr 3, 2026

Backporting JDK-8354695: Open source several swing tests batch7. Adds seven javax/swing tests. Ran GHA Sanity Checks and (non-windows) new tests directly. Patch is clean. Backporting for parity with Oracle.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8354695 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8354695: Open source several swing tests batch7 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4354/head:pull/4354
$ git checkout pull/4354

Update a local copy of the PR:
$ git checkout pull/4354
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4354

View PR using the GUI difftool:
$ git pr show -t 4354

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4354.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Apr 3, 2026

👋 Welcome back ssubramaniam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

@satyenme This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8354695: Open source several swing tests batch7

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport cc9148ddef95c6ca27ff9fee4c17fb0d4ba7f88e 8354695: Open source several swing tests batch7 Apr 3, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Apr 3, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 3, 2026

⚠️ @satyenme This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 3, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Apr 3, 2026

Webrevs

@satyenme
Copy link
Copy Markdown
Author

satyenme commented Apr 6, 2026

/approval request for backport of JDK-8354695: Open source several swing tests batch7

Motivation: With this change, we provide additional test coverage without changing any functionality (so minimal risk). Change will bring openjdk closer to matching oracle.

Risk: Low. Ran GHA Sanity Checks and new manual tests. Patch is clean. Although change has only been present in tip since April, 2025, change has been accepted by Oracle (and tests were previously closed source).

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@satyenme
8354695: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Apr 6, 2026
Copy link
Copy Markdown
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch verified clean when compared to openjdk/jdk21u-dev#2810 and new tests pass (though status of JScrollPane/AcceleratedWheelScrolling/HorizScrollers.java unclear as Windows only)

@gnu-andrew
Copy link
Copy Markdown
Member

/approve yes

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@gnu-andrew
8354695: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Apr 6, 2026
@satyenme
Copy link
Copy Markdown
Author

satyenme commented Apr 6, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

Going to push as commit 2dded17.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 6, 2026
@openjdk openjdk bot closed this Apr 6, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 6, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Apr 6, 2026

@satyenme Pushed as commit 2dded17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants