Repository navigation
add UI support for repo field in search results - #304
Mansi2007275 wants to merge 4 commits into
Conversation
|
A couple days before your change, #302 was merged which handles the But the bigger issue is that we removed Flask entirely from this repository recently, so your work was on the old UI, oops! We want this change on the new React-based front-end, which currently looks like this:
I'm thinking we want something like the version number tag (in the above screenshot, it's "0.2.0-1"), perhaps in another color? For sources that come from the IBM Validated software list. |
ee3cf62 to
8c2cc9c
Compare
|
Hi @pleia2, @vmuralictr thanks for the feedback! I've updated the PR to work with the new React/Node.js stack instead of the old Flask-based UI. Removed the old Flask-based changes (src/classes/package_search.py, src/static/js/views/home.html) since Flask has been removed from the repo |
|
if there any issue then do let me know sorry for the delay |
pleia2
left a comment
There was a problem hiding this comment.
We'll also need the DCO sign-off on the commits 😄
|
Hi @pleia2, Thanks for the feedback! I've made the following changes: Removed the link — changed the repo tag from a clickable link to a plain , since the repo field isn't a URL. It now displays the actual repo text (e.g. "FTP3 Product-SLES16.0 Pool scc repository") instead of the hardcoded "Validated" label. Let me know if any further changes are needed! |
|
Hi @Mansi2007275, thanks for the contribution! I tested your PR locally and found a few things to fix before we can merge:
|
|
@Mansi2007275 Have you had a chance to look at @vmuralictr's comments above? I'm hoping to do some user testing over the next couple weeks, and it would be great to have this feature land before that. |
Signed-off-by: Mansi2007275 <yadavmansi0111207@gmail.com>
- Show repo as plain text (not a link) since it is not a URL - Add optional Show Repository checkbox to toggle visibility Signed-off-by: Mansi2007275 <yadavmansi0111207@gmail.com>
Signed-off-by: Mansi2007275 <yadavmansi0111207@gmail.com>
a9e3f6a to
256ed23
Compare
|
@vmuralictr please review this i have done if further changes required then please tell me |
|
@vmuralictr please review this too please i really wnat it so please review it |
Signed-off-by: Mansi2007275 <yadavmansi0111207@gmail.com>
vmuralictr
left a comment
There was a problem hiding this comment.
Hi @Mansi2007275, the technical fixes look good — repo in all SELECT queries, correct Vite env var, DCO signoff all confirmed ✓
Before we merge, PR
#333 (filter sidebar) also modifies SearchBar.jsx significantly, so we'd like to merge that one first to avoid conflicts. Once it's in, please rebase this PR on top of it — your changes are small and should apply cleanly. We'll ping you when it's ready!
|
Thanks for the review @vmuralictr. Understood, I'll wait for #333 to be merged and then rebase this PR on top of it. Please ping me when it's ready |


Summary
Closes #265
Adds optional UI support for the
repofield now presentin PDS data sources.
Changes Made
bin/database_build.pyrepocolumn to MySQL table schema increateTable()jsontosql()to handle all INSERT casessrc/classes/package_search.pyrepoto both SELECT queries insearchSQLPackages()src/static/js/views/home.htmlexists, shows
—when absent