Repository navigation
feat: add production Docker setup for full stack deployment - #330
Merged
pleia2 merged 7 commits intoOct 6, 2026
Merged
Conversation
Closed
pleia2
self-requested a review
August 4, 2026 22:24
Contributor
|
I haven't had a chance to go through this fully, but since we're using Apache in our production recommendations, perhaps we should use it here as well instead of Nginx so we don't need to maintain two separate webserver configurations? |
…penmainframeproject#223) - Add react-frontend/Dockerfile: multi-stage build (Node 22 builder + nginx:alpine to serve dist/) - Add react-frontend/nginx.conf: proxies /sdt/ to backend, supports React Router via try_files fallback - Update backend/Dockerfile: bump Node 20 -> 22, use node index.js directly, switch to --omit=dev - Add docker-compose.yml: wires frontend + backend + MariaDB 11 with health check dependency ordering - Add .env.example at repo root for docker-compose secrets - Add .dockerignore for both frontend and backend
- backend: fix build context to repo root so bin/, distro_data/, config/ are accessible - backend: copy bin/ and distro_data/ into image for database_build.js to work - docker-compose: remove backend port 5000 host mapping (nginx handles routing) - docker-compose: set backend build context to repo root with explicit dockerfile path - frontend: switch npm ci to npm install --legacy-peer-deps to fix peer dep errors - frontend: add VITE_REACT_APP_API_URL build arg so API calls go through nginx proxy
vmuralictr
force-pushed
the
feat/docker-production-223
branch
from
August 31, 2026 17:07
b3127c0 to
8c9fb40
Compare
pleia2
requested changes
Sep 11, 2026
pleia2
left a comment
Contributor
There was a problem hiding this comment.
Works and looks good, just two tiny things to adjust to get to perfect 😄
- Specify Docker Compose plugin version 2 or above (Linux) - Add git pull commands to fetch latest submodule data after clone
pleia2
approved these changes
Oct 6, 2026
Contributor
|
@vmuralictr What should our process be when the Frontend Security Audit check fails? |
2 tasks
pleia2
approved these changes
Oct 6, 2026
pleia2
reviewed
Oct 6, 2026
pleia2
left a comment
Contributor
There was a problem hiding this comment.
Failing test fixed in follow-up PR, moving forward with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #223
Adds a complete production-ready Docker setup for the full stack:
react-frontend/Dockerfile— multi-stage build: Node 22 builds the Vite app, nginx:alpine serves the compileddist/react-frontend/nginx.conf— proxies/sdt/to the backend container, supports React Router viatry_filesfallbackbackend/Dockerfile— bumps Node 20 → 22, switches tonode index.jsdirectly, uses--omit=devdocker-compose.yml— wires frontend + backend + MariaDB 11 with health check dependency ordering so backend waits for DB to be ready.env.example(repo root) — documents the secrets needed for docker-compose.dockerignorefiles for both frontend and backendUsage
cp .env.example .env # Edit .env with your passwords docker compose up --buildThe app will be available at
http://localhost.Test plan
docker compose up --buildcompletes without errorshttp://localhostdocker compose down -vcleans up correctly