[ISSUE #262]Dledger polish project#263
Open
mxsm wants to merge 7 commits intoopenmessaging:masterfrom
Open
Conversation
RongtongJin
reviewed
Nov 28, 2022
Contributor
RongtongJin
left a comment
There was a problem hiding this comment.
Whether it is necessary to extract the common module separately because the core and the common module are used together now
dledger/pom.xml
Outdated
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <artifactId>dledger</artifactId> | ||
| <artifactId>dledger-core</artifactId> |
Contributor
There was a problem hiding this comment.
To ensure compatibility, it would be better not to modify the artifactId.
Contributor
Author
command module is noly for CLI , it can't start dledger server. Multi-Raft start with proxy module and normal start with dledger module. so add common module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracing #262