-
-
Notifications
You must be signed in to change notification settings - Fork 213
[MNT] Intermediate test plan #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1629 +/- ##
==========================================
+ Coverage 52.04% 52.75% +0.71%
==========================================
Files 36 36
Lines 4333 4333
==========================================
+ Hits 2255 2286 +31
+ Misses 2078 2047 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Docker fails to build for Windows, given that the image of database are built using Linux binaries. It works locally because Docker Desktop ends up using WSL in the background (as far as I can understand) to run these containers without errors. Currently I am skipping running docker for the windows env during CI runs only, and using this for tests that will end up using the docker servers: is_windows_ci = (sys.platform == "win32" or os.name == "nt") and os.environ.get("CI") == "true"
skip_on_windows_ci = pytest.mark.skipif(
is_windows_ci,
reason="Skipping Docker tests on Windows CI (No WSL2 available)"
)
# Used in the form:
@skip_on_windows_ci
def test_database_connection():
...Since we eventually plan on migrating all tests to these local servers, and we would like windows to run them too, we should think of another method to run these tests on windows CI. |
Metadata
Details
This PR implements the setting up of the v1 and v2 test servers using docker via
localhostwheneverpytestis run, eventually we plan to migrate fully over to these tests instead of usingtest.openml.org.docker-compose.yml.docker/update.shfrom the server-api repository to setup the test server.test.ymlandconftest.pyto run the containers on CI and locally.