Skip to content

Conversation

@satvshr
Copy link
Contributor

@satvshr satvshr commented Jan 29, 2026

Metadata

Details

  • What does this PR implement/fix? Explain your changes.
    This PR implements the setting up of the v1 and v2 test servers using docker via localhost whenever pytest is run, eventually we plan to migrate fully over to these tests instead of using test.openml.org.
    • Add docker-compose.yml.
    • Add docker/update.sh from the server-api repository to setup the test server.
    • Changes to test.yml and conftest.py to run the containers on CI and locally.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.75%. Comparing base (d421b9e) to head (f169950).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1629      +/-   ##
==========================================
+ Coverage   52.04%   52.75%   +0.71%     
==========================================
  Files          36       36              
  Lines        4333     4333              
==========================================
+ Hits         2255     2286      +31     
+ Misses       2078     2047      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satvshr satvshr marked this pull request as ready for review January 31, 2026 16:13
@satvshr satvshr marked this pull request as draft January 31, 2026 16:14
@satvshr
Copy link
Contributor Author

satvshr commented Feb 2, 2026

Docker fails to build for Windows, given that the image of database are built using Linux binaries. It works locally because Docker Desktop ends up using WSL in the background (as far as I can understand) to run these containers without errors. Currently I am skipping running docker for the windows env during CI runs only, and using this for tests that will end up using the docker servers:

is_windows_ci = (sys.platform == "win32" or os.name == "nt") and os.environ.get("CI") == "true"
skip_on_windows_ci = pytest.mark.skipif(
    is_windows_ci,
    reason="Skipping Docker tests on Windows CI (No WSL2 available)"
)

# Used in the form:
@skip_on_windows_ci
def test_database_connection():
    ...

Since we eventually plan on migrating all tests to these local servers, and we would like windows to run them too, we should think of another method to run these tests on windows CI.

@satvshr satvshr marked this pull request as ready for review February 3, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT] Intermediate test plan

2 participants