Skip to content

Conversation

@LDSamson
Copy link
Collaborator

@LDSamson LDSamson commented Jan 5, 2026

Closes #263. See also #223 (comment).

This should make the app faster at start up but also after saving a review.

@LDSamson LDSamson changed the title Ls refactor summary data Refactor summary data Jan 5, 2026
@LDSamson LDSamson added the enhancement New feature or request label Jan 5, 2026
@LDSamson LDSamson linked an issue Jan 5, 2026 that may be closed by this pull request
@LDSamson LDSamson marked this pull request as ready for review January 5, 2026 15:19
@LDSamson
Copy link
Collaborator Author

LDSamson commented Jan 6, 2026

@jthompson-arcus new method is about a factor 3 faster when I do a quick benchmark on a big dataset (using the code below and setting duplications to 100, and then using a microbenchmark to compare both versions): #223 (comment).

Biggest change comes from the change of summarize_review_data().
Removing temp_table creation in the SQL code and removing the indexing does not change much in speed so we could remove that to reduce complexity. Or remove the SQL query if you think it is not worth to change to this pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor summary data

3 participants