Skip scoped .class references in AddConfigurationAnnotationIfBeansPresent#1007
Merged
Skip scoped .class references in AddConfigurationAnnotationIfBeansPresent#1007
.class references in AddConfigurationAnnotationIfBeansPresent#1007Conversation
…Present` Convert the recipe to a `ScanningRecipe` that first collects FQNs of classes referenced as scoped configuration via `.class` literals in `@FeignClient`, `@EnableFeignClients`, `@LoadBalancerClient`, and `@LoadBalancerClients`, then skips adding `@Configuration` to those classes so their per-client/per-target scope is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddConfigurationAnnotationIfBeansPresentto aScanningRecipethat first collects FQNs of classes referenced as scoped configuration via.classliterals in@FeignClient/@LoadBalancerClient(configurationattr) and@EnableFeignClients/@LoadBalancerClients(defaultConfigurationattr).@Configurationto those collected classes so their per-client / per-target scope is preserved, addressing the concern from Remove AddConfigurationAnnotationIfBeansPresent from SpringBoot2BestPractices (fixes #1002) #1003 (comment).defaultConfigurationattributes, plus a negative test ensuring unrelated configs still get@Configuration.Test plan
./gradlew test --tests AddConfigurationAnnotationIfBeansPresentTest(9/9 pass)