Draft
Conversation
Use same hierarchy calculation methods for cached hierarchy and that calculated during compatibility checks
CodelistVersion._calculate_new_style_hierarchy() creates a hierarchy from a codelistversion's code_objs. _create_version_with_codes() followed the logic of CodelistVersion._calculate_old_style_hierarchy() which creates a hierarchy from a codelistversion's codes. The latter includes only included codes, the former includes excluded codes that are hierarchically related to the included. Where the latter and the former are not equal then this can produce different hierarchies. By no longer passing the old-style-calculated hierarchy (which is the only style of hierarchy we can calculate before we've got code_objs, and we need it to create the code_objs) to cache_hierarchy we force it to calculate a new-style one for us before caching it. This ensures that the cached hierarchy is calculated in a manner consistent with the model's calculate_hierarchy()
Deleting a search can remove unresolved codes from a CodelistVersion's code_objs These code_objs are used to calculate the CodelistVersion's Hierarchy Therefore, if we change the code_objs, we should recalculate the cached hierarchy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP